Don’t overwrite supervisor config

Bug #1433046 reported by Aleksey Zvyagintsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
In Progress
Medium
Bulat Gaifullin
6.0.x
Won't Fix
Medium
Ihor Kalnytskyi
7.0.x
Won't Fix
Medium
Ihor Kalnytskyi
8.0.x
Won't Fix
Medium
Bulat Gaifullin
Mitaka
Won't Fix
Medium
Bulat Gaifullin
Newton
In Progress
Medium
Bulat Gaifullin

Bug Description

Due upgrade process, superviors configs overwrites by function from :
https://github.com/stackforge/fuel-web/blob/master/fuel_upgrade_system/fuel_upgrade/fuel_upgrade/utils.py#L170-L184

using this template
https://github.com/stackforge/fuel-web/blob/master/fuel_upgrade_system/fuel_upgrade/fuel_upgrade/templates/supervisor.conf

So, that means - partial loosing configuration from :
(at least, prioritizing)
https://github.com/stackforge/fuel-library/tree/master/deployment/puppet/docker/files/supervisor

Please, refactor this function for merge process, or something else.

Revision history for this message
Evgeniy L (rustyrobot) wrote :

I can suggest the next flow.

If there is config, don't generate own config and use existing instead.
During the upgrade autostart parameter should be set for existing config accordingly to upgrade logic.

If there is no config for service, upgrade script should generate it's own config.
It's required because Docker upgrade can be run without any other upgrade engines, it simplifies testing and debugging process.

Changed in fuel:
importance: Undecided → High
status: New → Confirmed
assignee: nobody → Fuel Python Team (fuel-python)
milestone: none → 6.1
tags: added: upgrade
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: Confirmed → Triaged
Dmitry Pyzhov (dpyzhov)
tags: added: feature-upgrade
removed: upgrade
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Igor Kalnitsky (ikalnitsky)
Revision history for this message
Aleksey Zvyagintsev (azvyagintsev) wrote :

Guys, please move fix-time at least in 6.1

Dmitry Pyzhov (dpyzhov)
tags: added: tricky
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

We agreed that this bug is Medium and can be moved to 7.0

Changed in fuel:
importance: High → Medium
milestone: 6.1 → 7.0
Revision history for this message
Vladimir Sharshov (vsharshov) wrote :

Known issue. Can be safely moved to 8.0

tags: added: known-issue
Changed in fuel:
milestone: 7.0 → 8.0
assignee: Igor Kalnitsky (ikalnitsky) → Fuel Python Team (fuel-python)
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Bulat Gaifullin (bgaifullin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222051

Changed in fuel:
status: Triaged → In Progress
Dmitry Pyzhov (dpyzhov)
tags: added: feature
Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/8.0.x
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Igor Kalnitsky (<email address hidden>) on branch: master
Review: https://review.openstack.org/222051
Reason: It was decided to use backup-restore upgrade approach . Moreover, fuel-upgrade has its own repo now.

Changed in fuel:
milestone: 8.0 → 9.0
tags: added: wontfix-workaround
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.