Nodes are deleted inefficiently in nailgun.
Bug #1429014 reported by
Maciej Kwiek
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Committed
|
Medium
|
Maciej Kwiek |
Bug Description
There are several places in code where nodes are deleted by getting them from db, iterating over them and calling `delete` method on each object. It should be done differently, by deleting nodes in bulks.
summary: |
- Nodes are deleted inefficiently. + Nodes are deleted inefficiently in nailgun. |
Changed in fuel: | |
assignee: | Fuel Python Team (fuel-python) → Maciej Kwiek (maciej-iai) |
status: | New → In Progress |
Changed in fuel: | |
importance: | Undecided → Medium |
milestone: | none → 6.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/161788 /git.openstack. org/cgit/ stackforge/ fuel-web/ commit/ ?id=6f75452d296 524868d7922b80e e3ba385f3c96c0
Committed: https:/
Submitter: Jenkins
Branch: master
commit 6f75452d2965248 68d7922b80ee3ba 385f3c96c0
Author: Maciej Kwiek <email address hidden>
Date: Mon Mar 2 14:28:34 2015 +0100
Delete nodes in batch instead of iterating
Nodes were deleted by getting them from database, then iterating over
them, which was not efficient. Now they are deleted in batch.
Node model has a new method: delete_by_ids, which does just that.
Change-Id: Icc1fe51ebf31f1 53fe0b630295306 0c5f2d7267c
Closes-Bug: #1429014