Fuel for OpenStack

make iso failures result in broken loopback devices

Bug #1427170 reported by Matthew Mosesohn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Alexei Sheplyakov
Fuel for OpenStack 6.1
6.0.x
Won't Fix
High
Fuel build team
Fuel for OpenStack 6.0-updates

Bug Description

If a make iso process fails, it doesn't clean up loopback devices correctly when trying to run make deep_clean. I get errors like this one:
sudo rm -rf /home/mmosesohn/fuel-main/build/image/centos
rm: cannot remove ‘/home/mmosesohn/fuel-main/build/image/centos/SANDBOX/tmp/imgcreate-naPJfy/install_root/sys’: Device or resource busy

It seems like the sandbox mount point needs to be detached/unmounted before trying to delete the image build directory.

Tags: size-s
Matthew Mosesohn (raytrac3r)
Changed in fuel:
assignee: nobody → Fuel build team (fuel-build)
status: New → Confirmed
importance: Undecided → Critical
milestone: none → 6.1
Dmitry Pyzhov (dpyzhov)
tags: added: size-s
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165794

Changed in fuel:
assignee: Fuel build team (fuel-build) → Alexei Sheplyakov (asheplyakov)
status: Confirmed → In Progress
Revision history for this message
Alexei Sheplyakov (asheplyakov) wrote :

Also I suggest to run the ISO build in a (per build) VM

Revision history for this message
Alexei Sheplyakov (asheplyakov) wrote :

The patch fixing the issue has been proposed 3 weeks ago, yet nobody (including the reported) have bothered to review/test it. Perhaps the problem is not so serious. Adjusting the Importance accordingly.

Changed in fuel:
importance: Critical → Medium
Revision history for this message
Michael Semenov (msemenov) wrote :

Matthew, please look at this patch https://review.openstack.org/#/c/165794/
If it works for you, please merge it and close the issue.

Changed in fuel:
assignee: Alexei Sheplyakov (asheplyakov) → Matthew Mosesohn (raytrac3r)
Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

+1 marked. passing back

Changed in fuel:
assignee: Matthew Mosesohn (raytrac3r) → Alexei Sheplyakov (asheplyakov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/165794
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=a8556ad4749a94eb2b724cc00b8db86067bc982c
Submitter: Jenkins
Branch: master

commit a8556ad4749a94eb2b724cc00b8db86067bc982c
Author: Alexei Sheplyakov <email address hidden>
Date: Thu Mar 19 15:04:06 2015 +0300

    image/centos: umount filesystems under the image build directory

    ... before trying to remove that directory. No busy loopback devices
    are hanging around after a failed build any more.

    Closes-Bug: #1427170

    Change-Id: I72a6e58f0501e73996964bc033556747b56c43bf

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.