Remove fake mode from DeletionTask

Bug #1421599 reported by Przemyslaw Kaminski
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
Medium
Roman Prykhodchenko

Bug Description

According to comments in

https://review.openstack.org/#/c/151648/6/nailgun/nailgun/task/task.py
https://review.openstack.org/#/c/151648/7/nailgun/nailgun/task/task.py

let us remove use_fake and 'nodes_to_restore' value, simplifying also prepare_nodes_for_task function's return value. The shortcut of not calling Astute when there are no nodes can be removed too (in the execute function).

Changed in fuel:
status: New → Confirmed
tags: added: low-hanging-fruit
Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
removed: nailgun
tags: added: qa-agree-7.0
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Roman Prykhodchenko (romcheg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/240936

Changed in fuel:
status: Confirmed → In Progress
Dmitry Pyzhov (dpyzhov)
tags: added: tricky
tags: removed: low-hanging-fruit
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

After discussing this bug we decided that fixing it brings more complexity to the production code than resolves. Instead, we should think about how to get rid of fake threads at all.

Changed in fuel:
status: In Progress → Won't Fix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Roman Prykhodchenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/240936
Reason: The bug won't be fixed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.