Same ip permitted in ui for dns in neutron l3 setup.

Bug #1413182 reported by Piotr Skamruk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Alexandra Morozova
6.0.x
Won't Fix
Medium
Fuel Python (Deprecated)

Bug Description

In time of environment configuration, on network tab, in neutron l3 configuration there are 2 inputs for dns servers.
Webui permits to set same address in both fields, but later, in deploy time - neutron fails to setup Net04 (private network) with this filled settings.

First thing connected to this - there is no possibility to configure there only one dns server.
Second - there should be check (preferably on both sides, on client and on server) if there are same addresses in this fields.

Łukasz Oleś (loles)
tags: added: customer-found
Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

I see a few options to fix it:

1) Fix manifests to handle empty second DNS server

2) Also allow empty DNS server in UI my bodifying regexp in openstack.yaml

3) Complete fix - support any amount of DNS servers in UI and network API

Revision history for this message
Piotr Skamruk (jell) wrote :

This would be fix for first issue - environment with one dns server address.

Second issue with same address in both fields - should be verified by ui.

Changed in fuel:
milestone: none → 6.1
importance: Undecided → Medium
Changed in fuel:
assignee: nobody → Fuel UI Team (fuel-ui)
Changed in fuel:
status: New → Confirmed
Revision history for this message
Ryan Moe (rmoe) wrote :

Ran into this on another deployment. For the sake of searching here's what's in the logs when this happens:

In puppet-apply.log:
2015-02-27T07:57:28.444820+00:00 notice: (Puppet::Type::Neutron_subnet::ProviderNeutron) Neutron API not avalaible. Wait up to 27 sec.
2015-02-27T07:57:30.447289+00:00 debug: Executing '/usr/bin/neutron subnet-create --format=shell --name=net04__subnet --gateway-ip=10.0.0.1 --enable-dhcp --dns-nameserver=10.54.8.248 --dns-nameserver=10.54.8.248 --tenant_id=c449999a65284ed9a61256465a00a2a3 net04 10.0.0.0/21'
2015-02-27T07:58:21.707690+00:00 err: did not get expected message on subnet creation, got
(followed by a Ruby traceback)

In neutron-server.log
2015-02-27 07:57:28.355 65859 TRACE neutron.api.v2.resource Traceback (most recent call last):
2015-02-27 07:57:28.355 65859 TRACE neutron.api.v2.resource File "/usr/lib/python2.6/site-packages/neutron/api/v2/resource.py", line 87, in resource
2015-02-27 07:57:28.355 65859 TRACE neutron.api.v2.resource result = method(request=request, **args)
2015-02-27 07:57:28.355 65859 TRACE neutron.api.v2.resource File "/usr/lib/python2.6/site-packages/neutron/api/v2/base.py", line 379, in create
2015-02-27 07:57:28.355 65859 TRACE neutron.api.v2.resource allow_bulk=self._allow_bulk)
2015-02-27 07:57:28.355 65859 TRACE neutron.api.v2.resource File "/usr/lib/python2.6/site-packages/neutron/api/v2/base.py", line 642, in prepare_request_body
2015-02-27 07:57:28.355 65859 TRACE neutron.api.v2.resource raise webob.exc.HTTPBadRequest(msg)
2015-02-27 07:57:28.355 65859 TRACE neutron.api.v2.resource HTTPBadRequest: Invalid input for dns_nameservers. Reason: Duplicate nameserver '10.108.20.48'.

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Fuel Python Team (fuel-python)
Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

I suggest to add this check to check_networks task - so it will be checked both on UI and nailgun site. If it is possible to use only 1 DNS server or more than 2 and our manifests support it, I suggest to create another bug/blueprint for this

Dmitry Pyzhov (dpyzhov)
tags: added: feature-validation
removed: ui
Dmitry Pyzhov (dpyzhov)
tags: added: feature
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

DNS servers list is just a list in Nailgun (json field in DB that is treated as list). Seems nothing is to be changed there. And it is propagated into orchestrator as list. Probably it supports any number of DNS's too.

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

A check should be added to check_networks task in Nailgun.

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Yes, manifests support any number of DNS servers.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Aleksey Kasatkin (alekseyk-ru)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170209

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Piotr Skamruk (jell) wrote :

This fix partially resolves issue (but does it IMO in right way). Again there is no way to set only one dns server address.

Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

There also will be fix for UI also which will allow setting arbitrary amount of DNS servers

Changed in fuel:
importance: Medium → Low
importance: Low → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/170209
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=beb0c28fdfa8fa2f7f781b91b6a724cb9e5930c8
Submitter: Jenkins
Branch: master

commit beb0c28fdfa8fa2f7f781b91b6a724cb9e5930c8
Author: Aleksey Kasatkin <email address hidden>
Date: Thu Apr 2 19:53:02 2015 +0300

    DNS servers IPs equality check is added

    Partial-Bug: #1413182
    Change-Id: Ib279dfe7f4b29b6d89b7ad7b732b72b680d554d8

Changed in fuel:
assignee: Aleksey Kasatkin (alekseyk-ru) → Vitaly Kramskikh (vkramskikh)
Changed in fuel:
assignee: Vitaly Kramskikh (vkramskikh) → Alexandra Morozova (astepanchuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/171207
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=dca90feb4694c1c731930613b3ec0832efcf9e1c
Submitter: Jenkins
Branch: master

commit dca90feb4694c1c731930613b3ec0832efcf9e1c
Author: Alexandra Morozova <email address hidden>
Date: Tue Apr 7 15:59:27 2015 +0200

    Support for multiple DNS on UI

     - added new component to handle multiple values

    Partial-Bug: #1413182

    Change-Id: Iddc58aed9973cfafe4d7e9d920ab3636d5f481e4

Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

This bug should be fixed now:

1) There is a check for duplicate IP addresses

2) UI allows to set arbitrary amount of DNS servers

Changed in fuel:
status: In Progress → Fix Committed
tags: added: featue-validation on-verification
removed: feature-validation
Revision history for this message
Anastasia Palkina (apalkina) wrote :

Verified on ISO #394

"build_id": "2015-05-08_10-07-32", "build_number": "394", "release_versions": {"2014.2.2-6.1": {"VERSION": {"build_id": "2015-05-08_10-07-32", "build_number": "394", "api": "1.0", "fuel-library_sha": "f385d6a58298c702f8d4f14c452dcffdc0b1e2a3", "nailgun_sha": "46f55c293e4540d31bcaa6ca3fba77235fb27537", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "af6c9c3799b9ec107bcdc6dbf035cafc034526ce", "astute_sha": "6a4dcd11c67af2917815f3678fb594c7412a4c97", "fuel-ostf_sha": "740ded337bb2a8a9b3d505026652512257375c01", "release": "6.1", "fuelmain_sha": "3eca5e8f7ca6a83faff5feeca92c21cff31c0af1"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "f385d6a58298c702f8d4f14c452dcffdc0b1e2a3", "nailgun_sha": "46f55c293e4540d31bcaa6ca3fba77235fb27537", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "af6c9c3799b9ec107bcdc6dbf035cafc034526ce", "astute_sha": "6a4dcd11c67af2917815f3678fb594c7412a4c97", "fuel-ostf_sha": "740ded337bb2a8a9b3d505026652512257375c01", "release": "6.1", "fuelmain_sha": "3eca5e8f7ca6a83faff5feeca92c21cff31c0af1"

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.