Fuel for OpenStack

Incorrect docstring in Environment.create in fuelclient

Bug #1405640 reported by Julia Portnova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Vladimir Sharshov
Fuel for OpenStack 6.1

Bug Description

Docstring says that default value for deployment mode is multinode but default is ha_compact:

https://github.com/stackforge/fuel-web/blob/master/fuelclient/fuelclient/cli/actions/environment.py#L79

Also why do we set deployment_mode with additional command and not passing it to create? It is bit unconvenient
https://github.com/stackforge/fuel-web/blob/master/fuelclient/fuelclient/cli/actions/environment.py#L92

See original description
Julia Portnova (yportnova)
description: updated
Dima Shulyak (dshulyak)
Changed in fuel:
importance: Undecided → Medium
assignee: nobody → Fuel Python Team (fuel-python)
milestone: none → 6.1
status: New → Triaged
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

>> Also why do we set deployment_mode with additional command and not passing it to create?
>> https://github.com/stackforge/fuel-web/blob/master/fuelclient/fuelclient/cli/actions/environment.py#L92

This looks very strange to me. API allows single-call creation. UI creates env using single call and provides 'mode' there always.

Revision history for this message
Julia Portnova (yportnova) wrote :

>> This looks very strange to me. API allows single-call creation. UI creates env using single call and provides 'mode' there always.

We are using fuelclient for certification and create environment with Environment.create method. It is really strange that we cannot pass mode directly to this method.

Maybe file another bug with this issue?
Although we have a bp https://blueprints.launchpad.net/fuel/+spec/refactoring-for-fuelclient so I am not sure if we need a bug here

Dmitry Pyzhov (dpyzhov)
tags: added: module-client
Vladimir Sharshov (vsharshov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Vladimir Sharshov (vsharshov)
Revision history for this message
Vladimir Sharshov (vsharshov) wrote :

Create separate bug about additional command for env mode: https://bugs.launchpad.net/fuel/+bug/1440807

Changed in fuel:
status: Triaged → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170928

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/170928
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=30c8ce5cd074c8897960fa3a7f24d6a1165011ea
Submitter: Jenkins
Branch: master

commit 30c8ce5cd074c8897960fa3a7f24d6a1165011ea
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Mon Apr 6 20:10:10 2015 +0300

    Default value for deployment mode is ha_compact

    Closes-Bug #1405640

    Change-Id: Ifb66b0e4b675c9537bee89f23d55bd0e9f73cebd

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.