[ui] It's impossible to delete node from deployed environment

[Julia Aranovich]

Steps to reproduce:
1. deploy an environment;
2. delete some nodes (mark it as 'pending_deletion')

Expected result:
Deploy Changes button is available due to changes in env nodes.

Actual result:
Deploy changes button id locked. It is impossible to start deployment and undeploy selected nodes.

[Przemyslaw Kaminski (pkaminski)]

Well, it is caused by this check (in nailgun/static/js/views/cluster_page_subviews.jsx):

disabled = {... || !nodes.reject({status: 'ready'}).length }

which actually can be written more cleary & efficiently in this way:

disabled = { ... || nodes.every({status: 'ready'}) }

So my question is: why do we check if every node is ready? Shouldn't we also include a 'pending_deletion' check there? So the above condition would be rewritten as

disabled = {... || nodes.every({status: 'ready', pending_deletion: false}) }

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145491

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145491
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=7dbffc22947bc3e2ae0971b31899c92127c78054
Submitter: Jenkins
Branch: master

commit 7dbffc22947bc3e2ae0971b31899c92127c78054
Author: Przemyslaw Kaminski <email address hidden>
Date: Wed Jan 7 14:03:30 2015 +0100

    Fix nodes check for disabling the deploy button

    Change-Id: I24405155931f5ff5813dc0bf6539c9ec76e9cf67
    Closes-Bug: #1405635

[Anastasia Palkina (apalkina)]

Verified on ISO #58

"build_id": "2015-01-13_21-50-03", "ostf_sha": "0c1b663c6fc02ad972f2ed9ff6b000e7be1ea207", "build_number": "58", "auth_required": true, "api": "1.0", "nailgun_sha": "6fa6147384b533fb3d56cdc49ec6ecbcca47675d", "production": "docker", "fuelmain_sha": "", "astute_sha": "82125b0eef4e5a758fd4afa8917812e09a1f7dac", "feature_groups": ["mirantis"], "release": "6.1", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2015-01-13_21-50-03", "ostf_sha": "0c1b663c6fc02ad972f2ed9ff6b000e7be1ea207", "build_number": "58", "api": "1.0", "nailgun_sha": "6fa6147384b533fb3d56cdc49ec6ecbcca47675d", "production": "docker", "fuelmain_sha": "", "astute_sha": "82125b0eef4e5a758fd4afa8917812e09a1f7dac", "feature_groups": ["mirantis"], "release": "6.1", "fuellib_sha": "c53cb3a2bd5f99f32f78ed18e9472724fa6a9a9e"}}}, "fuellib_sha": "c53cb3a2bd5f99f32f78ed18e9472724fa6a9a9e"

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/149638

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/156576

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149638
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=d302363b7e1b6b6fb3831ce4a930258f89162283
Submitter: Jenkins
Branch: master

commit d302363b7e1b6b6fb3831ce4a930258f89162283
Author: Przemyslaw Kaminski <email address hidden>
Date: Fri Jan 23 14:59:58 2015 +0100

    Node(s) DELETE is done via the removal task

    The DELETE method now returns task object that removes this node from DB and
    from Cobbler. Also, DELETE method for collection has been added that accepts
    a list of ids to delete and performs batched removal.

    Change-Id: Ib976278eb5436d4dbb3d8b6be11a90902a0f8871
    Closes-Bug: #1411200
    Implements blueprint: node-removal-task
    Related-Bug: #1405635

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/156576
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=f0e238858c8bc65a5869f0ec81ec8d8ffe4fa6cd
Submitter: Jenkins
Branch: master

commit f0e238858c8bc65a5869f0ec81ec8d8ffe4fa6cd
Author: Przemyslaw Kaminski <email address hidden>
Date: Tue Feb 17 14:18:16 2015 +0100

    Added 'removing' state to nodes

    This is in the same spirit as already-existing 'deploying' and
    'provisioning' status for nodes.

    Implements blueprint node-removal-task
    Related-Bug: #1405635

    Change-Id: I5eafff3cc9a064cd324712ef70fe1547563272f4