Usage statistics isn't sent if postgres was restarted

[Artem Panchenko]

api: '1.0'
astute_sha: 16b252d93be6aaa73030b8100cf8c5ca6a970a91
auth_required: true
build_id: 2014-12-09_22-41-06
build_number: '49'
feature_groups:
- mirantis
fuellib_sha: 2c99931072d951301d395ebd5bf45c8d401301bb
fuelmain_sha: 3aab16667f47dd8384904e27f70f7a87ba15f4ee
nailgun_sha: 22bd43b89a17843f9199f92d61fc86cb0f8772f1
ostf_sha: a9afb68710d809570460c29d6c3293219d3624d4
production: docker
release: '6.0'

After 'postgres' docker container restart 'statsenderd' begins to return 'DatabaseError' and can't send usage statistics.

Steps to reproduce:

1. Install Fuel 6.0
2. Enable sending of usage information
3. Restart 'postgres' docker container (dockerctl restart postgres)
4. Check that 'statsenderd' logs

Expected result:

- usage stats are sent correctly

Actual:

- 'statsenderd' can't send stats due to database connection errors:

http://paste.openstack.org/show/149280/

This issue can be fixed by 'statsenderd' service restart

# dockerctl shell nailgun supervisorctl restart statsenderd

[Nastya Urlapova (aurlapova)]

Guys, I am pretty sure, what it is no Medium priority.

[Aleksey Kasatkin (alekseyk-ru)]

First error that occurs is: http://paste.openstack.org/show/149762/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/141387

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/141431

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/141387
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=24f9c78dd40b2425f6626ea2dcffbd4acdb4607e
Submitter: Jenkins
Branch: master

commit 24f9c78dd40b2425f6626ea2dcffbd4acdb4607e
Author: Aleksey Kasatkin <email address hidden>
Date: Fri Dec 12 16:09:45 2014 +0200

    Close DB session in StatsSender.run

    DB session.remove() is called in StatsSender.run loop.
    Now it fails once after postgres restart and works fine in next iteration.

    Change-Id: I7c31e37184139e950e400a8dba4bcd2e86b3c8ef
    Closes-Bug: #1401521

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/141431
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=c5fa761684a5e8263847ce921a0d4f7121bad849
Submitter: Jenkins
Branch: stable/6.0

commit c5fa761684a5e8263847ce921a0d4f7121bad849
Author: Aleksey Kasatkin <email address hidden>
Date: Fri Dec 12 16:09:45 2014 +0200

    Close DB session in StatsSender.run

    DB session.remove() is called in StatsSender.run loop.
    Now it fails once after postgres restart and works fine in next iteration.

    Change-Id: I7c31e37184139e950e400a8dba4bcd2e86b3c8ef
    Closes-Bug: #1401521

[Artem Panchenko (apanchenko-8)]

verified on 6.0:

api: '1.0'
astute_sha: 16b252d93be6aaa73030b8100cf8c5ca6a970a91
auth_required: true
build_id: 2014-12-18_01-32-01
build_number: '56'
feature_groups:
- mirantis
fuellib_sha: 73332192a257ea02c40a39885c502ad1ebdf3eda
fuelmain_sha: 45caacadb878abfbd9d60e134d72229698b469c9
nailgun_sha: 5f91157daa6798ff522ca9f6d34e7e135f150a90
ostf_sha: a9afb68710d809570460c29d6c3293219d3624d4
production: docker
release: '6.0'

[Andrey Sledzinskiy (asledzinskiy)]

verified on {

    "build_id": "2015-01-21_22-54-45",
    "ostf_sha": "c94d4dc4fde6fbd18bdfbb508f5e12e9188ad725",
    "build_number": "74",
    "auth_required": true,
    "api": "1.0",
    "nailgun_sha": "22321c5529ef95ff6586079894916f8963f4079e",
    "production": "docker",
    "fuelmain_sha": "",
    "astute_sha": "f640780d1c7ebe89e4f343736500945525799ee0",
    "feature_groups":

[

    "mirantis"

],
"release": "6.1",
"release_versions":
{

    "2014.2-6.1":

{

    "VERSION":

{

    "build_id": "2015-01-21_22-54-45",
    "ostf_sha": "c94d4dc4fde6fbd18bdfbb508f5e12e9188ad725",
    "build_number": "74",
    "api": "1.0",
    "nailgun_sha": "22321c5529ef95ff6586079894916f8963f4079e",
    "production": "docker",
    "fuelmain_sha": "",
    "astute_sha": "f640780d1c7ebe89e4f343736500945525799ee0",
    "feature_groups":

                [
                    "mirantis"
                ],
                "release": "6.1",
                "fuellib_sha": "1050db4614a0ee347757bf5aa41308a319943758"
            }
        }
    },
    "fuellib_sha": "1050db4614a0ee347757bf5aa41308a319943758"

}