Fuel for OpenStack

fpb validation wrongly assumes yaml structure

Bug #1396491 reported by Andrew Woodward
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Evgeniy L
Fuel for OpenStack 6.0

Bug Description

in environment_config.yaml this is the default
----
attributes:
  pumphouse_text:
    value: 'Set default value'
    label: 'Text field'
    description: 'Description for text field'
    weight: 25
    type: "text"
----

however if i don't need to create any settings, a minimum of
----
attributes:
  type:
    moon:
----
is required, even though it's wrong yaml syntax

Tags: plugin
Nastya Urlapova (aurlapova)
Changed in fuel:
assignee: nobody → Evgeniy L (rustyrobot)
Evgeniy L (rustyrobot)
Changed in fuel:
assignee: Evgeniy L (rustyrobot) → Fuel Python Team (fuel-python)
milestone: none → 6.0
importance: Undecided → High
status: New → Confirmed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugins (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138458

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Evgeniy L (rustyrobot)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/138696

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Evgeniy L (<email address hidden>) on branch: master
Review: https://review.openstack.org/138696
Reason: attributes should not be None

see discussion https://review.openstack.org/#/c/138458/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-plugins (master)

Reviewed: https://review.openstack.org/138458
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugins/commit/?id=11dcdf26849c828246e5578c89e9c5ae08ef20ad
Submitter: Jenkins
Branch: master

commit 11dcdf26849c828246e5578c89e9c5ae08ef20ad
Author: Evgeniy L <email address hidden>
Date: Tue Dec 2 20:40:33 2014 +0400

    Fpb, do not fail validation if 'attributes' is not set

    * Fixed validation for environment_config.yaml file, "attributes"
      field is optional
    * Improved validation for, added required fields for attributes

    Change-Id: I6a8a5b3864fd0bfb760d4f852fb95a9208a4c1d3
    Closes-bug: #1396491

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.