[plugins] User friendly error message instead of exception

[Nastya Urlapova]

{
build_id: "2014-11-24_11-04-14",
ostf_sha: "a35f516f1606b0d03d51ff63bfe3fbe23de4b622",
build_number: "553",
auth_required: true,
api: "1.0",
nailgun_sha: "a226336a81afc95781ff854ff07c6bd71f281fc1",
production: "docker",
fuelmain_sha: "fc6331ac5e553f3317bbb44625d7d57d1f234a33",
astute_sha: "c15623d05ccdf7ac10873e7a90df954de8726280",
feature_groups: [
"mirantis"
],
release: "6.0",
release_versions: {
2014.2-6.0: {
VERSION: {
build_id: "2014-11-24_11-04-14",
ostf_sha: "a35f516f1606b0d03d51ff63bfe3fbe23de4b622",
build_number: "553",
api: "1.0",
nailgun_sha: "a226336a81afc95781ff854ff07c6bd71f281fc1",
production: "docker",
fuelmain_sha: "fc6331ac5e553f3317bbb44625d7d57d1f234a33",
astute_sha: "c15623d05ccdf7ac10873e7a90df954de8726280",
feature_groups: [
"mirantis"
],
release: "6.0",
fuellib_sha: "2bfa9431a4839efae9c75d6b133df24c0f11c868"
}
}
},
fuellib_sha: "2bfa9431a4839efae9c75d6b133df24c0f11c868"
}

1. install master node
2. install plugin, in my case it is lbaas-1.0.0.fp
from https://fuel-jenkins.mirantis.com/job/stackforge-build-fuel-plugins/
"installation succeeded"
3. try install second time >
fuel plugins --install lbaas-1.0.0.fp
>>>
409 Client Error: Conflict ({"description": "Enables LBaaS for Neutron, works in multinode mode only", "releases": [{"repository_path": "repositories/ubuntu", "version": "2014.2-6.0", "os": "ubuntu", "mode": ["multinode"], "deployment_scripts_path": "deployment_scripts/"}, {"repository_path": "repositories/centos", "version": "2014.2-6.0", "os": "centos", "mode": ["multinode"], "deployment_scripts_path": "deployment_scripts/"}], "title": "LBaaS plugin for Neutron", "package_version": "1.0.0", "version": "1.0.0", "fuel_version": ["6.0"], "id": 1, "name": "lbaas"})

Let's provide human readable information instead of such stuff.

[Vladimir Sharshov (vsharshov)]

Current version fpb from master for plugins version 2.0 (rpm) now shows such message:

[root@fuel test]# fuel plugins --install test-1.0-1.0.0-0.noarch.rpm
DEPRECATION WARNING: file /etc/fuel/client/config.yaml is found and will be used as a source for settings. However, it deprecated and will not be used by default in the ongoing version of python-fuelclient.
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile
nailgun | 3.9 kB 00:00 ...
Setting up Install Process
Examining test-1.0-1.0.0-0.noarch.rpm: test-1.0-1.0.0-0.noarch
test-1.0-1.0.0-0.noarch.rpm: does not update installed package.
Error: Nothing to do
Shell command executed with "1" exit code: yum -y install test-1.0-1.0.0-0.noarch.rpm

This bug is actual only for old format.

[Vladimir Sharshov (vsharshov)]

Old version plugin format deprecated. This is problem with UX which mostly user will not see. Moving to 8.0

[Vladimir Sharshov (vsharshov)]

Need to be recheck.

[Vladimir Sharshov (vsharshov)]

Error still present, but we can decrease priority of bug to low, because it is actual only for deprecated format.

[root@nailgun ~]# fuel plugins --install test/test-1.0.0.fp
409 Client Error: Conflict ({"description": "Enable to use plugin X for Neutron", "releases": [{"repository_path": "repositories/ubuntu", "version": "2014.2-6.0", "os": "ubuntu", "mode": ["ha", "multinode"], "deployment_scripts_path": "deployment_scripts/"}, {"repository_path": "repositories/centos", "version": "2014.2-6.0", "os": "centos", "mode": ["ha", "multinode"], "deployment_scripts_path": "deployment_scripts/"}], "title": "Title for test plugin", "package_version": "1.0.0", "version": "1.0.0", "fuel_version": ["6.0"], "groups": [], "authors": [], "licenses": [], "homepage": null, "id": 1, "name": "test"})

[Dmitry Pyzhov (dpyzhov)]

We passed SCF in 8.0. Moving the bug to 9.0.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/301197

[Carlos Novo (cnovo-k)]

Proposed fix committed to https://review.openstack.org/301197

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/301197
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=9db6d710456dece28b3c9201cc8f7b64aafb78cd
Submitter: Jenkins
Branch: master

commit 9db6d710456dece28b3c9201cc8f7b64aafb78cd
Author: carlos.novo <email address hidden>
Date: Mon Apr 4 18:02:48 2016 +0100

    More friendly message reinstalling a v1.0 plugin.

    Now the code is showing a more friendly message to the user,
    instead of the full resp response.

    [root@fuel objects]# fuel plugins --install /tmp/lbaas-1.0.0.fp
    DEPRECATION WARNING: The plugin has old 1.0 package format, this
    format does not support many features, such as plugins updates,
    find plugin in new format or migrate and rebuild this one.
    Nothing to do: LBaaS plugin for Neutron, version 1.0.0, does not
    update installed plugin.

    Change-Id: I865c1024bde851bf4873aff4f775b8aac5329d35
    Closes-Bug: 1396154

[Alexandr Kostrikov (akostrikov-mirantis)]

Messages for failed installation of already installed plugin is tracked by rpm now:

[root@nailgun ~]# fuel plugins --install external_loadbalancer-2.0-2.0.0-1.noarch.rpm
Loaded plugins: fastestmirror, priorities
Examining external_loadbalancer-2.0-2.0.0-1.noarch.rpm: external_loadbalancer-2.0-2.0.0-1.noarch
external_loadbalancer-2.0-2.0.0-1.noarch.rpm: does not update installed package.
Error: Nothing to do
Shell command executed with "1" exit code: yum -y install --disablerepo='*' external_loadbalancer-2.0-2.0.0-1.noarch.rpm

The plugins which are mentioned in bug are no longer relevant, moving to invalid.

[Nastya Urlapova (aurlapova)]

>>>[root@nailgun ~]# fuel plugins --install fuel_plugin_example_v3-3.0-3.0.0-1.noarch.rpm
Loaded plugins: fastestmirror, priorities
Examining fuel_plugin_example_v3-3.0-3.0.0-1.noarch.rpm: fuel_plugin_example_v3-3.0-3.0.0-1.noarch
fuel_plugin_example_v3-3.0-3.0.0-1.noarch.rpm: does not update installed package.
Error: Nothing to do
Shell command executed with "1" exit code: yum -y install --disablerepo='*' fuel_plugin_example_v3-3.0-3.0.0-1.noarch.rpm
===
cat /etc/fuel_build_number:
 490
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8460.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8460.noarch
 fuel_plugin_example_v3-3.0-3.0.0-1.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8743.noarch
 fuel-notify-9.0.0-1.mos8460.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8460.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8743.noarch
 fuel-library9.0-9.0.0-1.mos8460.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos936.noarch
 fuelmenu-9.0.0-1.mos274.noarch
 fuel-nailgun-9.0.0-1.mos8743.noarch