Provide atop and screen to all nodes

[OpenStack Infra]

https://review.openstack.org/134554
commit a222976843ca2fdcce5be90de3352a842e78a9bb
Author: Oleksiy Molchanov <email address hidden>
Date: Fri Nov 14 16:53:08 2014 +0200

    Provide atop and screen to all nodes

    Provide installation and configuration
    of atop and screen to all nodes

    By default, make snapshot of system status each 20 seconds and keep
    them for 7 days locally for every node.
    It shows the occupation of the most critical hardware resources (from
    a performance point of view) on system level, i.e. cpu, memory, disk
    and network. Also:
    * Keep recorded data in binary format in /var/log/atop directory for
      7 days and delete an older ones by a logrotate job.
    * Additionally consumes maximum of 1.5G-2G of disk space for
      each node.
    * Add recorded atop data for the current day only (created as a symlink)
      to the diagnostic logs snapshot as well (bug/1389155).

    DocImpact
    Closes-Bug: 1385122

    Signed-off-by: Sergii Golovatiuk <email address hidden>
    Change-Id: Ib46ad049bc523f120da1ddaf20fb63a7b135153c

[Mykola Golub (mgolub)]

It looks like log rotation does not work as expected.

root@node-21:~# ls -lht /var/log/atop/*
-rw-r--r-- 1 root root 28M Mar 5 08:13 /var/log/atop/atop_20150305
lrwxrwxrwx 1 root root 27 Mar 5 07:35 /var/log/atop/atop_current -> /var/log/atop/atop_20150305
-rw-r--r-- 1 root root 0 Mar 5 07:35 /var/log/atop/daily.log
-rw-r--r-- 1 root root 89M Mar 5 00:00 /var/log/atop/atop_20150304-20150305
-rw-r--r-- 1 root root 80M Mar 4 00:00 /var/log/atop/atop_20150303-20150304
-rw-r--r-- 1 root root 81M Mar 3 00:00 /var/log/atop/atop_20150302-20150303-20150305
-rw-r--r-- 1 root root 81M Mar 2 00:00 /var/log/atop/atop_20150301-20150302-20150304
-rw-r--r-- 1 root root 82M Mar 1 00:00 /var/log/atop/atop_20150228-20150301-20150303-20150305
-rw-r--r-- 1 root root 80M Feb 28 00:00 /var/log/atop/atop_20150227-20150228-20150302-20150304
-rw-r--r-- 1 root root 85M Feb 27 00:00 /var/log/atop/atop_20150226-20150227-20150301-20150303-20150305
-rw-r--r-- 1 root root 81M Feb 26 00:00 /var/log/atop/atop_20150225-20150226-20150228-20150302-20150304

I left a more detailed comment in gerrit.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/179831

[Bogdan Dobrelya (bogdando)]

This bug cannot have a high deployment impact and will be addressed at the 7.0 release

[Alex Schultz (alex-schultz)]

Moved the log rotation issue to a new bug 1452389 since I think this is a bug for docs.

[Ryan Moe (rmoe)]

Is this bug not covered by this commit https://review.openstack.org/#/c/137474/?

[Evgeny Konstantinov (evkonstantinov)]

@Ryan, looks like it is.

[Sheena Conant (sheena-conant)]

@Ryan/Evgeny - is this bug already covered by an old commit? Can we close this bug?