fpb, build validation fails if environment_config has checkbox

Bug #1392807 reported by Evgeniy L
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Evgeniy L

Bug Description

[root@fuel fuel_plugin_name]# fpb --build .
2014-11-14 17:23:20 ERROR 28110 (cli) Wrong value format "attributes -> fuel_plugin_name_checkbox -> value", for file "./environment_config.yaml", False is not of type 'string'
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/cli.py", line 90, in main
    perform_action(args)
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/cli.py", line 77, in perform_action
    actions.BuildPlugin(args.build).run()
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/actions/build.py", line 42, in run
    self.check()
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/actions/build.py", line 99, in check
    self._check_structure()
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/actions/build.py", line 111, in _check_structure
    ValidatorManager(self.plugin_path).get_validator().validate()
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/validators/validator_v1.py", line 39, in validate
    self.check_schemas()
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/validators/validator_v1.py", line 47, in check_schemas
    self.validate_file_by_schema(v1.ENV_CONFIG_SCHEMA, self.env_conf_path)
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/validators/base.py", line 47, in validate_file_by_schema
    self.validate_schema(data, schema, path)
  File "/usr/lib/python2.6/site-packages/fuel_plugin_builder/validators/base.py", line 43, in validate_schema
    value_path, path, exc.message))
ValidationError: Wrong value format "attributes -> fuel_plugin_name_checkbox -> value", for file "./environment_config.yaml", False is not of type 'string'

attributes:

  fuel_plugin_name_checkbox:
    type: "checkbox"
    weight: 30
    value: false
    label: "Checkbox label"
    description: "Checkbox description"

Tags: plugins
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugins (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134614

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-plugins (master)

Reviewed: https://review.openstack.org/134614
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugins/commit/?id=9dd8d2a5fd9b16e730cee43e1342d2ca3177fdc7
Submitter: Jenkins
Branch: master

commit 9dd8d2a5fd9b16e730cee43e1342d2ca3177fdc7
Author: Evgeniy L <email address hidden>
Date: Fri Nov 14 21:06:00 2014 +0400

    fpb, value for elements in environment_config can be boolean

    * changed validation schema
    * add more elements examples for fuel_plugin_example

    Change-Id: Ifccd7db5c1fb1170ab538222b27e2e5c6c03f218
    Closes-bug: #1392807

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.