Remove unpacking code for docker images from upgrade.sh

Bug #1390030 reported by Ihor Kalnytskyi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Ihor Kalnytskyi

Bug Description

In Fuel 5.1.1/Fuel 6.0 we have an upgrade tarball packed with LRZ. The tarball includes already unpacked docker images:

    $ tree upgrade/images/
    upgrade/images/
    ├── astute.tar
    ├── busybox.tar
    ├── cobbler.tar
    ├── keystone.tar
    ├── mcollective.tar
    ├── nailgun.tar
    ├── nginx.tar
    ├── ostf.tar
    ├── postgres.tar
    ├── rabbitmq.tar
    ├── rsync.tar
    └── rsyslog.tar

So we should remove unpacking code from upgrade.sh in order to get rid of legacy code.

Here the code that should be removed:

    https://github.com/stackforge/fuel-main/blob/1f4e899b00ac5513eaa2d317e0a1c977c80e7137/upgrade/upgrade_template.sh#L19

Revision history for this message
Przemyslaw Kaminski (pkaminski) wrote :
Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Yep.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/133961

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Igor Kalnitsky (ikalnitsky)
status: Triaged → In Progress
Changed in fuel:
milestone: 6.1 → 6.0
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 6.0 → 6.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/133961
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=d0aa2868d88c60653e62666c568060370e913ee5
Submitter: Jenkins
Branch: master

commit d0aa2868d88c60653e62666c568060370e913ee5
Author: Igor Kalnitsky <email address hidden>
Date: Wed Nov 12 16:01:42 2014 +0200

    Remove unpacking for Docker images from upgrade.sh

    After make system refactoring an upgrade tarball contains unpacked
    Docker images, therefore we need to remove unnecessary unpacking code
    from upgrade.sh in order to get rid of legacy code.

    Also, the patch removes some obsolete targets from makefile.

    Change-Id: I043f000eca6f4aff1731e2bad49aae38e9a8d1f9
    Closes-Bug: #1390030

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.