Comment 4 for bug 1382527

Revision history for this message
Evgeniy L (rustyrobot) wrote :

>> The problem here is storage containers don't get made. They are all defined in the config.py for fuel_upgrade, but not a single one gets made

It's not correct, the problem is, they have different names.

https://github.com/stackforge/fuel-web/blob/master/fuel_upgrade_system/fuel_upgrade/fuel_upgrade/config.py#L556-L622

My suggestion for solving the problem is

Change prefix to "fuel-core-${VERSION}-storage-"
https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/docker/templates/dockerctl_config.erb#L41

Then, in upgrade system we will rename this volumes.
Here is a list of volume containers which we have

fuel-core-5.1-volume_repos
fuel-core-5.1-volume_logs
fuel-core-5.1-volume_ssh_keys
fuel-core-5.1-volume_dump
fuel-core-5.1-volume_fuel_configs
fuel-core-5.1-volume_puppet_manifests
fuel-core-5.1-volume_upgrade_directory

We'll change them to

fuel-core-5.1-storage-repo
fuel-core-5.1-storage-log
fuel-core-5.1-storage-puppet
# This volumes you don't create for some reasons
fuel-core-5.1-storage-fuel-configs
fuel-core-5.1-storage-ssh-keys
fuel-core-5.1-storage-dump
# This volume is required for upgrade only
fuel-core-5.1-storage-upgrade-directory

By the way in terms of docker these are volume containers, not "storages" and I would prefer to rename them to

fuel-core-5.1-volume-repo
fuel-core-5.1-volume-log
fuel-core-5.1-volume-puppet
fuel-core-5.1-volume-fuel-configs
fuel-core-5.1-volume-ssh-keys
fuel-core-5.1-volume-dump
fuel-core-5.1-volume-upgrade-directory

Also in dockerctl I can see, that some of the volumes are mounted directly into the containers, without volume containers, what is the point of making the same things in the different ways?