Fuel for OpenStack

[fuel-library] Hardcoded values for bridge names

Bug #1382526 reported by slava valyavskiy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Medium
Sergey Vasilenko
Fuel for OpenStack 6.1

Bug Description

Now, we have hardcoded value for bridges names in our puppet manifests:

https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/neutron/lib/puppet/parser/functions/sanitize_neutron_config.rb#L191-L197

In other hand, we have special section in node's yaml file called 'network_scheme/roles' where we have mapping between network name and bridge name what assigned to this network. And, when customers see that section they expected that this values are configurable. But, it's not right now. Let's take these values from yaml file.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129214

Changed in fuel:
assignee: nobody → slava valyavskiy (slava-val-al)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129347

Mike Scherbakov (mihgen)
Changed in fuel:
milestone: none → 6.0
Roman Prykhodchenko (romcheg)
Changed in fuel:
importance: Undecided → Medium
Vladimir Kuklin (vkuklin)
Changed in fuel:
milestone: 6.0 → 6.1
OpenStack Infra (hudson-openstack)
Changed in fuel:
assignee: slava valyavskiy (slava-val-al) → Aleksey Kasatkin (alekseyk-ru)
Sergey Vasilenko (xenolog)
Changed in fuel:
status: In Progress → Invalid
Revision history for this message
Sergey Vasilenko (xenolog) wrote :

part #1

> we have mapping between network name and bridge
This sentence is not correct.
Network roles mechanism -- is a mapping network role to endpoint.
Not a network to bridge.

integration and tunnel bridges -- is a part of internal neutron mechanics, that shouldn't be mapped to any network or interfaces.
It's just a bridges for technological purposes.

part #2
sanitize_neutron_config() function never used in any neutron manifests.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/170951

Aleksey Kasatkin (alekseyk-ru)
Changed in fuel:
assignee: Aleksey Kasatkin (alekseyk-ru) → Sergey Vasilenko (xenolog)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/170951
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=edc4ed4e1b46e09c1a6913850ccc2da42820a2e5
Submitter: Jenkins
Branch: master

commit edc4ed4e1b46e09c1a6913850ccc2da42820a2e5
Author: Sergey Vasilenko <email address hidden>
Date: Mon Apr 6 21:40:26 2015 +0300

    Remove unused function

    This function was used in old Neutron manifests implementation.
    After sync to upstream it is unused.

    Change-Id: I30236948cc0632637811cbfee394dc4a96124b6e
    Related-bug: #1382526

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Valyavskiy Viacheslav (<email address hidden>) on branch: master
Review: https://review.openstack.org/129214
Reason: function sanitize_neutron_config() never used in current manifests

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Valyavskiy Viacheslav (<email address hidden>) on branch: master
Review: https://review.openstack.org/129347

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.