fuel-library syntax check misses some bash scripts

Bug #1376254 reported by Aleksandra Fedorova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Aleksandr Didenko

Bug Description

We run syntax check only against *.sh files:

https://github.com/stackforge/fuel-library/blob/master/utils/jenkins/fuel_syntax_check.sh#L50

But there might be files like OCF-scripts here:

https://github.com/stackforge/fuel-library/tree/master/deployment/puppet/neutron/files/ocf/

We need to check them as well.

Changed in fuel:
milestone: none → 6.0
importance: Undecided → High
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Aleksandr Didenko (adidenko)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/126841

Changed in fuel:
status: New → In Progress
Revision history for this message
Sergey Vasilenko (xenolog) wrote :

I propose following workflow:

* all OCF scripts should placed at deployment/puppet/*/files/ocf/
* type of file in deployment/puppet/*/files/ocf/* detected fy 'file' utility
* this files should be tested, by corresponds his type tests.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/126841
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=b9176b28edbc48f08c3539547635502aff4effee
Submitter: Jenkins
Branch: master

commit b9176b28edbc48f08c3539547635502aff4effee
Author: Aleksandr Didenko <email address hidden>
Date: Wed Oct 8 11:55:47 2014 +0300

    Run syntax check for OCF scripts

    Make fuel_syntax_check.sh script run syntax check for any file
    found under "files/ocf/" subfolder in all puppet modules.

    Also bugfix for "rake spec" testing part of the script.

    Change-Id: I83c5bb1366b9284ff411c3e3e54e3a27c4049815
    Closes-bug: 1376254
    Closes-bug: 1378857
    DocImpact

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.