Fix setters in puppet providers

[Andrey Danin]

We found an issue with Ruby (see bug https://bugs.launchpad.net/fuel/+bug/1365449) in Puppet about setters for Puppet resource properties. It seems we should rewrite a usage of setters in our custom Puppet resource providers (at least in l23network) from code like this:
  def attr=(value)
  end
  def some_func (value)
    attr = value
  end
To (look at 'self' before 'attr'):
 def attr=(value)
  end
  def some_func (value)
    self.attr = (value)
  end

[Eugene Korekin (ekorekin)]

It should be 'self.attr=(value)' (without spaces, cause setter function defined as 'attr=')

[Dmitry Ilyin (idv1985)]

Actually it's a very funny Ruby problem

In ruby classes you can define setters and getters for a attributes:

def attr
  puts 'get attr'
  @attr
end

def attr=(value)
  puts 'set attr'
  @attr = value
end

then you can set and get this attr

put myclass.attr
myclass.attr = 1

Ok, then setter method is named 'attr=' what if i want to call if from within the class

attr = 1 -> it will not work. set local variable attr to 1
attr= 1 -> same
attr=(1) -> same

in this case we have to use self like in Python

self.attr = 1 -> ok using getter magic
self.attr= 1 -> ok calling directly
self.attr=(1) -> same

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119387

[Dmitry Ilyin (idv1985)]

This is ok too https://review.openstack.org/#/c/119175/

[Sergey Vasilenko (xenolog)]

It affects l23network

[Dmitry Ilyin (idv1985)]

But comment is not entirely correct

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: master
Review: https://review.openstack.org/119387
Reason: 1

[Dmitry Borodaenko (angdraug)]

Fixed in: https://review.openstack.org/#/c/119175/