Fuel for OpenStack

FuelMenu: Write tests for it

Bug #1365391 reported by Aleksey Kasatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Dmitry Guryanov
Fuel for OpenStack 9.0

Bug Description

Unit tests for fuel-menu are to be created.

Revision history for this message
Dmitry Mescheryakov (dmitrymex) wrote :

The bug does not belong to MOS, moving it to Fuel instead

affects: mos → fuel
Changed in fuel:
milestone: 6.0 → none
milestone: none → 6.0
Revision history for this message
Mike Scherbakov (mihgen) wrote :

I would say that it is low priority, as we don't do modification of this module.
The only modification we had recently was to add an ability to set initial password for Fuel UI. If we are about to rewrite it, or significantly extend - then yes, tests are mandatory.

Changed in fuel:
importance: Medium → Low
status: New → Confirmed
summary: - [fuel-menu] Write tests for fuel-menu
+ FuelMenu: Write tests for it
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 6.0 → 6.1
Evgeniy L (rustyrobot)
tags: added: size-l
Dmitry Pyzhov (dpyzhov)
tags: added: module-fuelmenu tech-debt
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 6.1 → next
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: next → 7.0
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
Nastya Urlapova (aurlapova)
Changed in fuel:
importance: Low → Medium
Sebastian Kalinowski (prmtl)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Sebastian Kalinowski (prmtl)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227251

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/227251
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=9214df4858cf58a070b011e056113ea52cd5d1dd
Submitter: Jenkins
Branch: master

commit 9214df4858cf58a070b011e056113ea52cd5d1dd
Author: Sebastian Kalinowski <email address hidden>
Date: Thu Sep 24 14:03:39 2015 +0200

    Enable writing tests for fuelmenu

    Added running tests with py.test in fuelmenu
    Added 2 simple tests for settings and cleaned settings.py a
    little bit
    Ignored tests .cache dir
    Removed not needed requirements.txt since setup.py has it all

    Change-Id: Id6869407273b38c57f3d3e7c8dff635829178348
    Partial-Bug: #1365391

Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Sebastian Kalinowski (prmtl)
Changed in fuel:
assignee: Sebastian Kalinowski (prmtl) → Fuel Python Team (fuel-python)
Alexander Kislitsky (akislitsky)
Changed in fuel:
milestone: 8.0 → 9.0
status: In Progress → Confirmed
Valentin Kaplov (vkaplov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Valentin Kaplov (vkaplov)
Valentin Kaplov (vkaplov)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/275630

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/277444

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/277864

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/277917

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/278262

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/278329

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/277917
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=d60323857052f6d1b53aa84ae8b9c355029e49e6
Submitter: Jenkins
Branch: master

commit d60323857052f6d1b53aa84ae8b9c355029e49e6
Author: Valentin Kaplov <email address hidden>
Date: Tue Feb 9 19:05:33 2016 +0300

    pwgen module unit test coverage

    Change-Id: I7442b2c97aab392f1adb1fe7d6ca8f34e63b6164
    Partial-Bug: #1365391

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/277444
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=710235c56bb3772ffd353780998538620b68987f
Submitter: Jenkins
Branch: master

commit 710235c56bb3772ffd353780998538620b68987f
Author: Valentin Kaplov <email address hidden>
Date: Mon Feb 8 18:23:24 2016 +0300

    dialog module unit test coverage

    Change-Id: I60f56f941bd93bbc2b74bc8cf2a6d5b5d0306cef
    Partial-Bug: #1365391

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/278262
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=8973df1bfc5ccf8b564545a9ca8c7050456eb07a
Submitter: Jenkins
Branch: master

commit 8973df1bfc5ccf8b564545a9ca8c7050456eb07a
Author: Valentin Kaplov <email address hidden>
Date: Wed Feb 10 12:13:13 2016 +0300

    replace module unit test coverage

    Also fixed file closing after reading.

    Change-Id: I8485fd35a2c7346ef2d38ffd7278fdaab6dc57ad
    Partial-Bug: #1365391

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Valentin Kaplov (vkaplov) → Fuel Python Team (fuel-python)
status: In Progress → Confirmed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Dmitry Guryanov (dguryanov)
OpenStack Infra (hudson-openstack)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-menu (master)

Change abandoned by Fedor Zhadaev (<email address hidden>) on branch: master
Review: https://review.openstack.org/278329
Reason: see https://review.openstack.org/#/c/282682

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/277864
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=23b5bb288bb00192954bdf75233cd16db96125d2
Submitter: Jenkins
Branch: master

commit 23b5bb288bb00192954bdf75233cd16db96125d2
Author: Valentin Kaplov <email address hidden>
Date: Tue Feb 9 17:52:22 2016 +0300

    puppet module unit test coverage

    Also refactored puppet module

    Co-Authored-By: Dmitry Guryanov <email address hidden>

    Change-Id: I36ff6d0cd5fe67e9a14c7c8a5940606cc0594e6d
    Partial-Bug: #1365391

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/275630
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=00d57070d01030044387ba8de33db1fd094b2e8a
Submitter: Jenkins
Branch: master

commit 00d57070d01030044387ba8de33db1fd094b2e8a
Author: Valentin Kaplov <email address hidden>
Date: Wed Feb 3 13:49:20 2016 +0300

    modulehelper module unit test coverage

    Also modulehelper have been refactored to make coverage easy.

    Co-Authored-By: Dmitry Guryanov <email address hidden>

    Change-Id: I36ec9a5bcdacf0c4604810a577508f9b0c026173
    Partial-Bug: #1365391

Revision history for this message
Dmitry Guryanov (dguryanov) wrote :

All patches have been committed.

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/311136

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/311136
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=31a06d5493437cf00adde8999f9fb1fcc142445f
Submitter: Jenkins
Branch: master

commit 31a06d5493437cf00adde8999f9fb1fcc142445f
Author: Mikhail <email address hidden>
Date: Fri Apr 29 17:52:06 2016 +0300

    cobblerconf module unit test coverage

    Change-Id: I06b041d46760fa5a5c388485baf034e7b1320ebe
    Partial-Bug: #1365391

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.