Remove fabric monkey patch from Shotgun

Bug #1358265 reported by Ihor Kalnytskyi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Ihor Kalnytskyi

Bug Description

Since the pull request for Fabric

    https://github.com/fabric/fabric/pull/1147

was merged and releases in Fabric 1.9.1, we should remove our hack from Shotgun:

    https://github.com/stackforge/fuel-web/blob/master/shotgun/shotgun/utils.py#L82

In order to get it done we need to make it in two steps:

1. Update Fabric version in python-fabric RPM package (https://bugs.launchpad.net/fuel/+bug/1372423).
2. Remove the hack from Shotgun.

Changed in fuel:
importance: Undecided → Medium
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/132890

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Igor Kalnitsky (ikalnitsky)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/132891

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 6.0 → 6.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144306

Changed in fuel:
assignee: Igor Kalnitsky (ikalnitsky) → Roman Vyalov (r0mikiam)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/144308

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/144308
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=3c08c212b0dfe676fc62725a407876b6ec29e728
Submitter: Jenkins
Branch: master

commit 3c08c212b0dfe676fc62725a407876b6ec29e728
Author: Igor Kalnitsky <email address hidden>
Date: Mon Dec 29 16:46:52 2014 +0200

    Don't hardcode strict Fabric version

    We need this patch as intermediate step in order to:

    * do not break building fuel master iso
    * to get new fabric in our mirrors

    Related change to fuel-main: I6755b6280f60b86affc8b051ab68bb52204f8810
    Related-Bug: #1358265

    Change-Id: Icab1b20fbabc49885a49fc9cdf17d6883fcdde28

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/144306
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=7c19916ab3708f9bf8fb41f6d2a0c0d3ad52e308
Submitter: Jenkins
Branch: master

commit 7c19916ab3708f9bf8fb41f6d2a0c0d3ad52e308
Author: Roman Vyalov <email address hidden>
Date: Mon Dec 29 17:30:44 2014 +0300

    Remove hardcode Fabric version in Shotgun requirements

    We need to use latest Fabric version with Shotgun.

    Change-Id: I6755b6280f60b86affc8b051ab68bb52204f8810
    Related-Bug: #1358265

Changed in fuel:
assignee: Roman Vyalov (r0mikiam) → Igor Kalnitsky (ikalnitsky)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/132890
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=ce48ad5f44bf4359f1a5f89679f5ff2cdee14e1c
Submitter: Jenkins
Branch: master

commit ce48ad5f44bf4359f1a5f89679f5ff2cdee14e1c
Author: Igor Kalnitsky <email address hidden>
Date: Wed Nov 5 19:21:03 2014 +0200

    Update Fabric version in Shotgun requirements

    In order to get rid of monkey patching we need to use latest Fabric
    version with Shotgun.

    Change-Id: I70b81bfbc038dbc12dcabfab0206606df8be4b22
    Closes-Bug: #1358265

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/132891
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=f8c4d6df89df1fd6478308c9e19bb9f035c5e29b
Submitter: Jenkins
Branch: master

commit f8c4d6df89df1fd6478308c9e19bb9f035c5e29b
Author: Igor Kalnitsky <email address hidden>
Date: Wed Nov 5 19:25:40 2014 +0200

    Remove Fabric monkey patching code

    We need to remove old hack since it's not needed in Fabric 1.9.1 and
    higher.

    Change-Id: I695afed31a2ff42129f4137ae721a008f09153e3
    Closes-Bug: #1358265

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.