incorrect processing finish / in parameter 'URL to NSX bits'

[Igor Gajsin]

When we choose network type 'Neutron with VMware NSX plugin' we must set a url for download specific packages. There is parameter 'URL to NSX bits' in tab 'settings' with comment 'specify valid http url (e.g. http://10.20.0.2/nsx)'.

But if we set url like this deploy will fail because fuel doesn't download packages. For success url must have finish '/' (i.e. http://10.20.0.2/nsx/).

[Igor Gajsin (igajsin)]

avior. It depend on settings of web-server. For example by default nginx work differently for locations '/path/to/package' and '/path/to/package/' but this feature may be changed by settings.
Also another web-servers may have another behavior.
When deploy Fuel doesn't check it but just hopes that URL-string and settings of web-server correspond to each other. If it doesn't happens deploy continues and has strange mistakes far-far away after error with downloads package.

Therefore I think Fuel must work correctly with finish '/' or drop deploy if it cann't download packages. First variant would be preffer.

[Igor Gajsin (igajsin)]

Sorry about misprint. First comment must begin from statement 'After investigate I have found the reason such behavior'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114295

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114295
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=2fd2b7831f9bca5df2fdb03ebf6bcd15873494ef
Submitter: Jenkins
Branch: master

commit 2fd2b7831f9bca5df2fdb03ebf6bcd15873494ef
Author: Igor Gajsin <email address hidden>
Date: Thu Aug 14 20:48:54 2014 +0400

    This fix cancel sensitivities to '/' in the end of 'urls of nsx bits' which may be reason of failed deploy for neutron with NSX.

    Also level of log messages changed to error when puppet can not download packages for correct work nsx.

    Closes-Bug: #1356294

    Change-Id: Ifce55943876d87ced49c9160f6b812ab71999341