[fuel-library] Puppet does not generate settings.yaml file correctly

[slava valyavskiy]

It's affect FUEL = 5.0 version & nailgun container

Puppet does not generate settings.yaml file correctly for options:
DNS_DOMAIN:""
DNS_SEARCH:""

As I see, now we use facter variables for DNS_DOMAIN and DNS_SEARCH options. - https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/nailgun/templates/settings.yaml.erb#L81-83
but facter util does not provide value of this variable if we us it in nailgun container.
[root@d8c020462465 ~]# facter domain
[root@d8c020462465 ~]#

File with wrong generated values is attached.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/108749

[Yuri Shovkoplias (yuri-shovkoplias)]

Dear product team,

Can we please get this resolved ASAP (e.g. in some ad-hoc version of the product)?
Need this to be a part of the distribution we use to deliver the acceptable ISO to our customer and redeploy the cloud, which we had to manually fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110021

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/110028

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/108749
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=e0be1c7372d32d687d32de3ea23967be261b8bec
Submitter: Jenkins
Branch: master

commit e0be1c7372d32d687d32de3ea23967be261b8bec
Author: vvalyavskiy <email address hidden>
Date: Tue Jul 22 19:40:39 2014 +0400

    Fix problem with domain name

    We can use variables from astute.yaml file instead facter variables

    Change-Id: I79c1782b5ccfe5776deb47c46e05f355364871ec
    Closes-Bug: #1346939

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/110021

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: stable/5.0
Review: https://review.openstack.org/110028

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/110241

[Vladimir Kuklin (vkuklin)]

{"build_id": "2014-07-29_21-55-53", "ostf_sha": "9c0454b2197756051fc9cee3cfd856cf2a4f0875", "build_number": "371", "auth_required": true, "api": "1.0", "nailgun_sha": "8cf375f7687d7d0797e7f085a909df8087fc82a6", "production": "docker", "fuelmain_sha": "83cb086fd292d23cb6b9d431ff30bfa28c8992cd", "astute_sha": "b16efcec6b4af1fb8669055c053fbabe188afa67", "feature_groups": ["mirantis"], "release": "5.1", "fuellib_sha": "5873ab37df3fd73074a0b443c1fa1fdf27cbab54"}

name resolving is still broken

on the master node I see

[root@nailgun ~]# cat /etc/resolv.conf
search domain.tld
domain test.domain.local
nameserver 10.108.0.2

[root@nailgun ~]# hostname -f
nailgun.test.domain.local

[root@nailgun ~]# ssh node-4
ssh: Could not resolve hostname node-4: Name or service not known

[root@nailgun ~]# ssh node-4.domain.tld
Warning: Permanently added 'node-4.domain.tld' (RSA) to the list of known hosts.
Welcome to Ubuntu 12.04.4 LTS (GNU/Linux 3.11.0-18-generic x86_64)

 * Documentation: https://help.ubuntu.com/
Last login: Tue Jul 29 20:12:43 2014 from 10.108.0.2

[Vladimir Kuklin (vkuklin)]

this breaks OSTF tests for nova-network connectivity

[Dmitry Borodaenko (angdraug)]

The reason for inconsistency in comment #10 is that fuelmenu ignores the domain settings passed by fuel system tests to fuel VM on boot via kernel parameters. Looks like the fix in https://review.openstack.org/108749 can only be safely applied after fuelmenu is fixed to recognize the kernel parameters instead of overriding them with its own defaults.

[Matthew Mosesohn (raytrac3r)]

Related bug: https://bugs.launchpad.net/fuel/+bug/1350395 should be implemented before reattempting this.

Dmitry B, your observation is good. The custom domain that is set in system tests I believe is being ignored by fuelmenu and creating inconsistencies that lead to dns resolution problems later. I will investigate that end as well, but keep in mind that these kernel options used by system tests are already discouraged in the User Guide and Fuelmenu is the real source of inputting data. Backward compatibility was added in because system tests can't control fuelmenu correctly yet (but I am working on this).

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: stable/5.0
Review: https://review.openstack.org/110241

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/111261

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/111261
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=b7b469f3604d6c9877d3f3077b08d29cd381c000
Submitter: Jenkins
Branch: master

commit b7b469f3604d6c9877d3f3077b08d29cd381c000
Author: vvalyavskiy <email address hidden>
Date: Tue Jul 22 19:40:39 2014 +0400

    Fix problem with domain name

    We can use variables from astute.yaml file instead facter variables

    Change-Id: Iefaf82afbfbecc503ace8e47f268bc344fe6e78a
    Closes-Bug: #1346939

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/114256

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: stable/5.0
Review: https://review.openstack.org/114256

[Anastasia Palkina (apalkina)]

Verified on ISO #11

"build_id": "2014-09-17_21-40-34", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "11", "auth_required": true, "api": "1.0", "nailgun_sha": "eb8f2b358ea4bb7eb0b2a0075e7ad3d3a905db0d", "production": "docker", "fuelmain_sha": "8ef433e939425eabd1034c0b70e90bdf888b69fd", "astute_sha": "f5fbd89d1e0e1f22ef9ab2af26da5ffbfbf24b13", "feature_groups": ["mirantis"], "release": "5.1", "release_versions": {"2014.1.1-5.1": {"VERSION": {"build_id": "2014-09-17_21-40-34", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "11", "api": "1.0", "nailgun_sha": "eb8f2b358ea4bb7eb0b2a0075e7ad3d3a905db0d", "production": "docker", "fuelmain_sha": "8ef433e939425eabd1034c0b70e90bdf888b69fd", "astute_sha": "f5fbd89d1e0e1f22ef9ab2af26da5ffbfbf24b13", "feature_groups": ["mirantis"], "release": "5.1", "fuellib_sha": "d9b16846e54f76c8ebe7764d2b5b8231d6b25079"}}}, "fuellib_sha": "d9b16846e54f76c8ebe7764d2b5b8231d6b25079"