[upgrade] upgrade procedure should update agent/mc agent/network checker

Bug #1343139 reported by Dima Shulyak
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
High
Fuel Python (Deprecated)

Bug Description

Packages fuel agent, mcollective agent and network checker are part of control plane and not openstack.

Not upgrading them means that bugs fixed in those packages wont affect already deployed nodes.
It also introduces some limitation on changing/adding actions to astute/network checker.

If this will be considered by design, atleast it should be fixed by puppet in case of environment patching, because as for now - they are installed by means of kickstart/preseed configurations.

Dmitry Ilyin (idv1985)
summary: - upgrade procedure should update agent/mc agent/netwrok checker
+ [upgrade] upgrade procedure should update agent/mc agent/netwrok checker
Evgeniy L (rustyrobot)
tags: added: patching upgrade
Changed in fuel:
status: New → Confirmed
Revision history for this message
Evgeniy L (rustyrobot) wrote : Re: [upgrade] upgrade procedure should update agent/mc agent/netwrok checker

Nailgun and Astute should support both versions of network checker.
Currently we cannot upgrade network checkers and mcollective agents, here are several reasons
1. it won't help, because after deployment user can run network checker on old cluster with new astute/nailgun
2. openstack patching feature was created to update minor changes for openstack, so, we cannot deliver code which breaks backward compatibility

Revision history for this message
Evgeniy L (rustyrobot) wrote :

Dmitry, do we have broken backward compatibility for network checker and mcollective plugins right now?

Revision history for this message
Dima Shulyak (dshulyak) wrote :

Network checker/mcollective verify networks compatibility will be fixed with this patch - https://review.openstack.org/#/c/107099/.

Cant say for other mcollective tasks..

1. it won't help, because after deployment user can run network checker on old cluster with new astute/nailgun

that is exectly the reason i created this bug, if we wont upgrade netwok checker/mcollective agents it will be quite easy to breake communication with slaves, perhaps i missed your point

Revision history for this message
Dima Shulyak (dshulyak) wrote :
Dima Shulyak (dshulyak)
summary: - [upgrade] upgrade procedure should update agent/mc agent/netwrok checker
+ [upgrade] upgrade procedure should update agent/mc agent/network checker
Revision history for this message
Evgeniy L (rustyrobot) wrote :

I've talked with Dmitry and he told me that right backward compatibility is not broken.

My suggestion is to add this case in test cases for upgrades and close the bug.

Revision history for this message
Evgeniy L (rustyrobot) wrote :

QA team, could you please make sure that you have such test case?

If yes, we can close this bug.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Fuel QA Team (fuel-qa)
Revision history for this message
Evgeniy L (rustyrobot) wrote :

Talked with Dmitry Pyzhov and Dmitry Shulyak, and it looks like we need a way to upgrade nechecker and mcagents.

Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Fuel Python Team (fuel-python)
Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

What about solution proposed by DShulyak? We can upgrade netchecker and mcagents withing openstack patching. All we need is to add ensures to our puppets.

Please correct me if I'm wrong.

Revision history for this message
Dima Shulyak (dshulyak) wrote :

It may be tricky to upgrade mcollective agents this way, we need to restart it, but astute polls mc agent.
So i'm +1 for postponing it, if this is not considered as big issue.

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Postponed to 6.0 due to discussion in mail list [1].

[1]: http://lists.openstack.org/pipermail/openstack-dev/2014-July/041110.html

Changed in fuel:
milestone: 5.1 → 6.0
Revision history for this message
Evgeniy L (rustyrobot) wrote :

It's not enough to just add 'ensure' for netchecker package in manifests, in this case rollback won't work because previous version of manifests don't have ensure for this package.

tags: added: release-notes
Changed in fuel:
milestone: 6.0 → 6.1
Revision history for this message
Dima Shulyak (dshulyak) wrote :

I hope it will be covered by patching story.
But it seems we are not going to include slaves update during master node upgrade script execution,
Evgeniy can you mark it as wont fix if it is true?

Dima Shulyak (dshulyak)
Changed in fuel:
status: Confirmed → Won't Fix
tags: added: release-notes-done
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-docs (stable/6.1)

Related fix proposed to branch: stable/6.1
Review: https://review.openstack.org/194961

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-docs (stable/6.1)
Download full text (45.4 KiB)

Reviewed: https://review.openstack.org/194961
Committed: https://git.openstack.org/cgit/stackforge/fuel-docs/commit/?id=0e26e7d7cc153d179ec34985645dd23cdd239ddb
Submitter: Jenkins
Branch: stable/6.1

commit 5cc5f0c643aebecaf3bf4580535a3ea7c3334a6c
Author: Mike Scherbakov <email address hidden>
Date: Tue Jun 23 13:43:35 2015 -0700

    Removed streamlined patching backend pieces

    Change-Id: I955e76ccdbd12a9145f4e9b689f80bdf9fcaf929

commit 563c4b5c78ebfcb1f4f91047c2919f6270f9a1d4
Author: Mike Scherbakov <email address hidden>
Date: Tue Jun 23 13:30:30 2015 -0700

    Removed outdated patching guide

    Change-Id: I76180c277789ade9c5ebedd19fe2092847c0b7d9

commit 8d120c14bec1ab41d448683ad146a3053a57c4ee
Author: Irina Povolotskaya <email address hidden>
Date: Tue Jun 23 19:59:11 2015 +0300

    Add dual hypervisor ref arch into 6.1 docs

    Change-Id: I900c24c9de878eafadbfc995aa879b7f55737fac

commit feebd1592d3305b64bbdfd0bc5fe108190aef120
Author: OlgaGusarenko <email address hidden>
Date: Tue Jun 23 18:38:17 2015 +0300

    [OPs guide] Running Ceilometer section edits

    1. conf file extract is updated
    2. note is updated

    Closes-bug: 1467817
    Change-Id: I0217e164108e0ba6c1397045a5e57d13ff429223

commit 44a93f9dead7511a3461ec35248dbb689c81eafd
Author: OlgaGusarenko <email address hidden>
Date: Tue Jun 23 18:04:40 2015 +0300

    [RN6_1] Final changes

    1. capitalization
    2. 2014.2 to 2014.2.2
    3. general improvements

    Change-Id: I45057e90c90550559f66bc67ccdf97a559fd9000

commit bb41389cae58084285688853281516b659686422
Author: evkonstantinov <email address hidden>
Date: Tue Jun 23 16:45:35 2015 +0300

    Update patching decription

    Update patching description with
    the standard Linux commands.

    Change-Id: Ia1a8346639c468fdfce15a11d2430bf3a4731244

commit bf3018fae3f2e564413d33aba6cdebf8868f0b4e
Author: OlgaGusarenko <email address hidden>
Date: Tue Jun 23 15:55:49 2015 +0300

    [RN6_1] Clean up

    1. Rearranges sections
    2. Improves RST
    3. Changes titles order

    Change-Id: I6110bf515667d3d6ba08ad35ff5d593dbc96641e

commit 1c7e4457808e8f2d6c56fdf31252170972e444b9
Author: Maria Zlatkova <email address hidden>
Date: Tue Jun 23 15:26:28 2015 +0300

    Replaces VBOX screenshots

    This patch:
    - replaces VBOX screenshots
    - changes the link for Download Mirantis VirtualBox scripts
     to https://docs.mirantis.com/openstack/fuel/fuel-master/#downloads

    Change-Id: I58dede960c5c3355d39b07ff44b757403f6af02c
    Closes-Bug: #1467872

commit 0a568bf53fc0e25d1d692d5d74b4a7b4d983bbcc
Author: evkonstantinov <email address hidden>
Date: Tue Jun 23 14:01:55 2015 +0300

    6.1 --separate repos

    change wording and add links to the
    separate repos feature.

    Change-Id: Ib5d0778a0d8f1534f79ed2f553574cb69a3150b0

commit 95a188b21cbdd064d92696b7920e6a0105fe0c56
Author: Maria Zlatkova <email address hidden>
Date: Tue Jun 23 12:07:28 2015 +0300

    Corrects the output 'pcs status'

    Changes the example outputs to appropriate ones.

    Change-Id: Ib6d83...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.