[nailgun] Set repo/puppet defaults in Nailgun, not in Astute

Bug #1342168 reported by Ihor Kalnytskyi on 2014-07-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Medium
Ihor Kalnytskyi

Bug Description

Currently repo/puppet defaults setuped in Astute:

    https://github.com/stackforge/fuel-astute/blob/master/lib/astute/deployment_engine.rb#L120

It's not obvious, since Nailgun has to manage this things.

Let's rewrite this in that way.

Changed in fuel:
milestone: none → 5.1
Dmitry Ilyin (idv1985) on 2014-07-15
summary: - Set repo/puppet defaults in Nailgun, not in Astute
+ [nailgun] Set repo/puppet defaults in Nailgun, not in Astute

Fix proposed to branch: master
Review: https://review.openstack.org/107184

Changed in fuel:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/107184
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=428e630ca998fa0b5f5e3a9918a01f2ed1dc5472
Submitter: Jenkins
Branch: master

commit 428e630ca998fa0b5f5e3a9918a01f2ed1dc5472
Author: Igor Kalnitsky <email address hidden>
Date: Tue Jul 15 18:32:15 2014 +0300

    Set default repos/puppets for releases

    Since Fuel 5.1 repos/puppets paths are sent by Nailgun to Astute.
    So we need to set defaults here, and remove them from Astute in
    order to make our code more clear and centralized.

    Closes-Bug: #1342168
    Change-Id: Id0917d1044824879d348cf1ff2f8fa1588d716fb

Changed in fuel:
status: In Progress → Fix Committed
Mike Scherbakov (mihgen) wrote :
Changed in fuel:
status: Fix Committed → Triaged

Fix proposed to branch: master
Review: https://review.openstack.org/107614

Changed in fuel:
status: Triaged → In Progress
Evgeniy L (rustyrobot) on 2014-07-17
tags: added: upgrade
removed: update

Reviewed: https://review.openstack.org/107614
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=5c28cd5511e2acd2a6277b67ec979af0632ffea2
Submitter: Jenkins
Branch: master

commit 5c28cd5511e2acd2a6277b67ec979af0632ffea2
Author: Igor Kalnitsky <email address hidden>
Date: Tue Jul 15 18:32:15 2014 +0300

    Set default repos/puppets for releases

    Since Fuel 5.1 repos/puppets paths are sent by Nailgun to Astute.
    So we need to set defaults here, and remove them from Astute in
    order to make our code more clear and centralized.

    Change-Id: I9bc5d7f4a3de76dd09fb8e45f5d50969e8f19138
    Closes-Bug: #1342168

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers