Puppet coding style

[Longgeek]

apt puppet module in fuel-library projects exist code standardization,
Run the rake lint follows the following output:

# cd fuel-library/deployment/puppet/apt
# rake lint

manifests/backports.pp - WARNING: class inheriting from params class on line 28
manifests/conf.pp - WARNING: defined type not documented on line 1
manifests/force.pp - WARNING: line has more than 80 characters on line 26
manifests/force.pp - WARNING: line has more than 80 characters on line 27
manifests/force.pp - WARNING: line has more than 80 characters on line 31
manifests/force.pp - WARNING: line has more than 80 characters on line 33
manifests/init.pp - WARNING: line has more than 80 characters on line 39
manifests/key.pp - WARNING: defined type not documented on line 1
manifests/key.pp - WARNING: line has more than 80 characters on line 13
manifests/key.pp - WARNING: line has more than 80 characters on line 38
manifests/key.pp - WARNING: line has more than 80 characters on line 56
manifests/key.pp - WARNING: line has more than 80 characters on line 73
manifests/params.pp - WARNING: class not documented on line 1
manifests/ppa.pp - WARNING: double quoted string containing no variables on line 18
manifests/ppa.pp - WARNING: line has more than 80 characters on line 22
manifests/ppa.pp - WARNING: line has more than 80 characters on line 43
manifests/ppa.pp - WARNING: line has more than 80 characters on line 51
manifests/release.pp - WARNING: parameterised class parameter without a default value on line 4
manifests/unattended_upgrades.pp - WARNING: parameterised class parameter without a default value on line 17
manifests/unattended_upgrades.pp - WARNING: parameterised class parameter without a default value on line 17
manifests/unattended_upgrades.pp - WARNING: top-scope variable being used without an explicit namespace on line 17
manifests/unattended_upgrades.pp - WARNING: top-scope variable being used without an explicit namespace on line 17
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 19
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 20
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 21
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 22
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 26
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 30
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 31
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 32
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 33
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 34
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 35
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 36
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 37
manifests/unattended_upgrades.pp - WARNING: double quoted string containing no variables on line 38
manifests/update.pp - WARNING: class not documented on line 1

Which contains a large number of 'line has more than 80 characters' warning, this should be disabled in Rakefile

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/105014

[Aleksandr Didenko (adidenko)]

It's better to upgrade "apt" module to 1.6.0 - it looks like all those issues are fixed in 1.6.0 already.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/105014
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=d2b3d6ae688f4de992b51871c0f504d99ba52237
Submitter: Jenkins
Branch: master

commit d2b3d6ae688f4de992b51871c0f504d99ba52237
Author: Longgeek <email address hidden>
Date: Sun Jul 6 20:11:58 2014 +0800

    Update the puppet coding style

    Disable check in rakefile:
    * disable 80 chars
    * disable variable scope
    * disable class inherits from params class
    * disable class parameter defaults
    The remaining work is in the correction puppet code specifications

    Change-Id: I4448f1776ca3c7c3ea4a3bb64672785a62572663
    Closes-Bug: #1338228