[astute] undefined method `uids' for Array nodes_remover.rb:116:in `mclient_remove_piece_nodes'

[Vladimir Sharshov]

Problem in https://github.com/stackforge/fuel-astute/commit/2b3a8592cc71c6883d82f5bc4820641fba9292a2 "Avoid high load for Cobbler TFTP when delete many nodes."

Original reporter: Matthew Mosesohn.

Traceback:

2014-07-01T16:30:46 info: [374] Processing RPC call 'provision'
2014-07-01T16:30:46 info: [374] 'provision' method called with data: ...
2014-07-01T16:30:46 info: [374] Trying to instantiate cobbler engine: {"url"=>"http://10.20.0.2:80/cobbler_api", "username"=>"cobbler", "password"=>"cobbler", "master_ip"=>"10.20.0.2"}
2014-07-01T16:30:46 debug: [374] Cobbler options: {"url"=>"http://10.20.0.2:80/cobbler_api", "username"=>"cobbler", "password"=>"cobbler", "master_ip"=>"10.20.0.2"}
2014-07-01T16:30:46 debug: [374] Connecting to cobbler with: host: 10.20.0.2 port: 80 path: /cobbler_api
2014-07-01T16:30:46 debug: [374] Cobbler initialize with username: cobbler, password: cobbler
2014-07-01T16:30:46 info: [374] Trying to instantiate cobbler engine: {"url"=>"http://10.20.0.2:80/cobbler_api", "username"=>"cobbler", "password"=>"cobbler", "master_ip"=>"10.20.0.2"}
2014-07-01T16:30:46 debug: [374] Cobbler options: {"url"=>"http://10.20.0.2:80/cobbler_api", "username"=>"cobbler", "password"=>"cobbler", "master_ip"=>"10.20.0.2"}
2014-07-01T16:30:46 debug: [374] Connecting to cobbler with: host: 10.20.0.2 port: 80 path: /cobbler_api
2014-07-01T16:30:46 debug: [374] Cobbler initialize with username: cobbler, password: cobbler
2014-07-01T16:30:47 info: [374] System is not in cobbler: node-2
2014-07-01T16:30:47 debug: [374] Cobbler syncing
2014-07-01T16:30:49 info: [374] : Starting removing of nodes: ["2"]
2014-07-01T16:30:49 err: [374] Error running provisioning: undefined method `uids' for #<Array:0x00000002539ab0>, trace: /usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/nodes_remover.rb:116:in `mclient_remove_piece_nodes'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/nodes_remover.rb:110:in `block in mclient_remove_nodes'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/nodes_remover.rb:108:in `each_slice'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/nodes_remover.rb:108:in `with_index'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/nodes_remover.rb:108:in `mclient_remove_nodes'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/nodes_remover.rb:70:in `remove_nodes'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/nodes_remover.rb:29:in `remove'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/orchestrator.rb:150:in `remove_nodes'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/orchestrator.rb:56:in `provision'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/dispatcher.rb:41:in `provision'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/server.rb:129:in `dispatch_message'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/server.rb:92:in `block in dispatch'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/task_queue.rb:64:in `call'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/task_queue.rb:64:in `block in each'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/task_queue.rb:56:in `each'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/task_queue.rb:56:in `each'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/server.rb:90:in `each_with_index'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/server.rb:90:in `dispatch'
/usr/lib64/ruby/gems/2.1.0/gems/astute-0.0.2/lib/astute/server/server.rb:78:in `block in perform_main_job'
2014-07-01T16:30:49 debug: [374] Dispatching aborted by provision

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/104102

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/104102
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=4b5a0003f6c372229500f31b4a4e4d6708b154fb
Submitter: Jenkins
Branch: master

commit 4b5a0003f6c372229500f31b4a4e4d6708b154fb
Author: Vladimir Sharshov <email address hidden>
Date: Wed Jul 2 11:45:24 2014 +0400

    Fix bug with nodes deletion and add test to prevent this in future.

    Change-Id: I7e1b021b0c7d2b4032e559f13247e81dd4ca9181
    Closes-Bug: #1336654

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/105602

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/105602
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=5df009e8eab611750309a4c5b5c9b0f7b9d85806
Submitter: Jenkins
Branch: stable/5.0

commit 5df009e8eab611750309a4c5b5c9b0f7b9d85806
Author: Vladimir Sharshov <email address hidden>
Date: Wed Jul 2 11:45:24 2014 +0400

    Fix bug with nodes deletion and add test to prevent this in future.

    Change-Id: I7e1b021b0c7d2b4032e559f13247e81dd4ca9181
    Closes-Bug: #1336654
    (cherry picked from commit 4b5a0003f6c372229500f31b4a4e4d6708b154fb)