[nailgun] flake8 fails for fuelmenu in master

Bug #1334156 reported by Evgeniy L on 2014-06-25
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Critical
Evgeniy L

Bug Description

pep8 runtests: commands[0] | flake8 .
./fuelmenu/fuelmenu.py:16:1: F401 'itertools' imported but unused
import itertools
^
./fuelmenu/fuelmenu.py:318:5: H306 imports not in alphabetical order (common.pwgen, common.network)
    import common.network as network
    ^
Check for imports in alphabetical order.

    OpenStack HACKING guide recommendation for imports:
    imports in human alphabetical order

    Okay: import os\nimport sys\n\nimport nova\nfrom nova import test
    Okay: import os\nimport sys
    H306: import sys\nimport os
./fuelmenu/common/pwgen.py:16:1: H306 imports not in alphabetical order (string, random.choice)
from random import choice
^
Check for imports in alphabetical order.

    OpenStack HACKING guide recommendation for imports:
    imports in human alphabetical order

    Okay: import os\nimport sys\n\nimport nova\nfrom nova import test
    Okay: import os\nimport sys
    H306: import sys\nimport os
./fuelmenu/modules/servicepws.py:16:1: F401 'collections' imported but unused
import collections
^
./fuelmenu/modules/servicepws.py:48:45: E241 multiple spaces after ':'
                                    "value": pwgen.password()},
                                            ^
    Avoid extraneous whitespace in the following situations:

    - More than one space around an assignment (or other) operator to
      align it with another.

    Note: these checks are disabled by default

    Okay: a = (1, 2)
    E241: a = (1, 2)
    E242: a = (1,\t2)
./fuelmenu/modules/servicepws.py:54:46: E241 multiple spaces after ':'
                                     "value": pwgen.password()},
                                             ^
    Avoid extraneous whitespace in the following situations:

    - More than one space around an assignment (or other) operator to
      align it with another.

    Note: these checks are disabled by default

    Okay: a = (1, 2)
    E241: a = (1, 2)
    E242: a = (1,\t2)
./fuelmenu/modules/servicepws.py:60:50: E241 multiple spaces after ':'
                                         "value": pwgen.password()},
                                                 ^
    Avoid extraneous whitespace in the following situations:

    - More than one space around an assignment (or other) operator to
      align it with another.

    Note: these checks are disabled by default

    Okay: a = (1, 2)
    E241: a = (1, 2)
    E242: a = (1,\t2)
7
ERROR: InvocationError: '/home/eli/job/fuel-web/fuelmenu/.tox/pep8/bin/flake8 .'
___________________________________________________________ summary ____________________________________________________________
ERROR: pep8: commands failed
Failed tests: flake8_checks

Reviewed: https://review.openstack.org/102464
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=a02d261353e0a52d7bba845b260f9db5f9ecea1b
Submitter: Jenkins
Branch: master

commit a02d261353e0a52d7bba845b260f9db5f9ecea1b
Author: Evgeniy L <email address hidden>
Date: Wed Jun 25 12:35:10 2014 +0400

    Fix flake8 for fuelmenu

    Change-Id: I835f8424135e0773dae62436bea4b26739e19ad9
    Closes-bug: #1334156

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Ilyin (idv1985) on 2014-07-16
summary: - flake8 fails for fuelmenu in master
+ [nailgun] flake8 fails for fuelmenu in master
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers