[systest] Snapshot was not created for test in error state

[Tatyanka]

http://jenkins-product.srt.mirantis.net:8080/view/4.1_swarm/job/4.1_fuelmain.system_test.centos.thread_1/163/console

There are not any snapshots fo failed tests. It is hard to understand what was happened.

[Nastya Urlapova (aurlapova)]

Incomplete after serial of cherry-picks.

[Tatyanka (tatyana-leontovich)]

Move to invalid, issue was caused by wrong job configuration. Do not reproduced last runs

[Artem Panchenko (apanchenko-8)]

This issue was reproduced during system tests in CI once again:

http://jenkins-product.srt.mirantis.net:8080/view/4.1_swarm/job/4.1_fuelmain.system_test.centos.thread_1/167/testReport/junit/(root)/deploy_neutron_gre/deploy_neutron_gre/

If creation of diagnostic snapshot fails, VMs snapshots also isn't created, so there is no way to investigate the problem. We need to add something like try/except there:

https://github.com/stackforge/fuel-main/blob/stable/4.1/fuelweb_test/helpers/decorators.py#L55

[Artem Panchenko (apanchenko-8)]

Also reproduced on master iso:

http://jenkins-product.srt.mirantis.net:8080/job/fuel_master_iso_smoke/950/console

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/108408

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/108408
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=c021106c9b61e34bc24ad464b42a6104ce66bb7a
Submitter: Jenkins
Branch: master

commit c021106c9b61e34bc24ad464b42a6104ce66bb7a
Author: Tatyana Leontovich <email address hidden>
Date: Mon Jul 21 16:20:39 2014 +0000

    Move create snapshot to finally block

    In case if create diagnostic snapshot failed,
    we can not create env snapshot with devops.
    To avoid this - move create snapshot in finally block

    Change-Id: I6826930d997006a51ca79b94314f7df3c06b2f66
    Closes-Bug: #1325907

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/108716

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/4.1
Review: https://review.openstack.org/108718

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/108718
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=095ca3b56a946370bb18c310a57edcd062d536ea
Submitter: Jenkins
Branch: stable/4.1

commit 095ca3b56a946370bb18c310a57edcd062d536ea
Author: Tatyana Leontovich <email address hidden>
Date: Mon Jul 21 16:20:39 2014 +0000

    Move create snapshot to finally block

    In case if create diagnostic snapshot failed,
    we can not create env snapshot with devops.
    To avoid this - move create snapshot in finally block

    Change-Id: I6826930d997006a51ca79b94314f7df3c06b2f66
    Closes-Bug: #1325907
    (cherry picked from commit c021106c9b61e34bc24ad464b42a6104ce66bb7a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/108716
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=6ce4fbabab43e5e35c97c889ef2a3706c6ad4af6
Submitter: Jenkins
Branch: stable/5.0

commit 6ce4fbabab43e5e35c97c889ef2a3706c6ad4af6
Author: Tatyana Leontovich <email address hidden>
Date: Mon Jul 21 16:20:39 2014 +0000

    Move create snapshot to finally block

    In case if create diagnostic snapshot failed,
    we can not create env snapshot with devops.
    To avoid this - move create snapshot in finally block

    Change-Id: I6826930d997006a51ca79b94314f7df3c06b2f66
    Closes-Bug: #1325907
    (cherry picked from commit c021106c9b61e34bc24ad464b42a6104ce66bb7a)