Shotgun cannot generate postgresql dump, or it runs postgres dump generation several times

Bug #1317018 reported by Evgeniy L
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Alexander Kislitsky

Bug Description

1. deepcopy settings before we are changing them, otherwise if user clicks several times dump button then shotgun will run postgresql dump several times

https://github.com/stackforge/fuel-web/blob/6b5e2797dae6a3b803b3ac7102ae3d9164a013cf/nailgun/nailgun/task/task.py#L648

2. when we run command shotgun from mcollective plugin, we doesn't set home directory. As result this code

https://github.com/stackforge/fuel-web/blob/6b5e2797dae6a3b803b3ac7102ae3d9164a013cf/shotgun/shotgun/driver.py#L229-L240

doesn't work because it expands to //.pgpass , pg_dump command expects /root/.pgpass .

There are several ways to solve this problem, for now we can just hardcode this path.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Alexander Kislitsky (akislitsky)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/92601

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/92601
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=2f7cf160ac96e745dcdce904ebbc507250304ce0
Submitter: Jenkins
Branch: master

commit 2f7cf160ac96e745dcdce904ebbc507250304ce0
Author: Alexander Kislitsky <email address hidden>
Date: Wed May 7 18:18:54 2014 +0400

    Shotgun PostgreSQL dump generation fixed

    Multiply writing dump_config into settings fixed.
    Path to .pgpass file fixed. Information from pwd used instead
    value of environment variable HOME

    Change-Id: Ib701a57fb6386d02cc93eb3d9f588f7abb1aac9f
    Closes-Bug: #1317018

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.