OSTF must be allowed if deployment failed

[Mike Scherbakov]

I had a failure in deployment, and was unable to run Health Check because
"You must deploy your OpenStack environment before running tests against it".

I think this behavior should be changed. I may have failure in, let's say, ceilometer installation, which doesn't affect operability of other OpenStack components. And I should be able to run OSTF to see what is actually functioning.

My ISO:
{"build_id": "2014-05-05_00-15-43", "mirantis": "yes", "build_number": "180", "ostf_sha": "134765fcb5a07dce0cd1bb399b2290c988c3c63b", "nailgun_sha": "2de1dcf9fa3fc1521999bff6377eaa6f01d825aa", "production": "docker", "api": "1.0", "fuelmain_sha": "95c35c199c2efc03fb105d090c5a42525430b7b3", "astute_sha": "3cffebde1e5452f5dbf8f744c6525fc36c7afbf3", "release": "5.0", "fuellib_sha": "2348fae80b21c3ec9e5f520395eea2943a510f3d"}

[Julia Aranovich (jkirnosova)]

On UI we check the following cases to lock the tab:
1. deployment task is in progress (this check remains unchanged)
2. environment has 'error' status (will be removed due to the ticket)
3. all nodes in environment have 'ready' status.

My question refers to the third point. Should we check node statuses? If yes, should we add 'error' node statuses as allowable for OSTF?

[Mike Scherbakov (mihgen)]

I think we should allow any status of nodes, except the case when env was never deployed. For example, if I added one node and started deployment, and something went wrong - OSTF should be enabled. If I added nodes to empty env and has not started deployment yet, then OSTF should be disabled.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/93293

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/93293
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=6982e7fb6caf94fd808fe911bd400ca8b8f9b68a
Submitter: Jenkins
Branch: master

commit 6982e7fb6caf94fd808fe911bd400ca8b8f9b68a
Author: Julia Aranovich <email address hidden>
Date: Mon May 12 15:31:21 2014 +0400

    Enable OSTF for error environment

    Closes-Bug:#1316127

    Change-Id: I0f8bba099b54a59efc359240171a6883023c9dd2

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/96744

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96744
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=92896013085e421741455292ce229de40088a28c
Submitter: Jenkins
Branch: master

commit 92896013085e421741455292ce229de40088a28c
Author: Tatyana Leontovich <email address hidden>
Date: Fri May 30 15:22:39 2014 +0000

    Raise SetProxy() exc if all controllers are off

    Raise SetProxy() exception if all
    controllers are offline

    Change-Id: Ia58dc50344b76ebd49ade827c4e79d9d9eeee62e
    Related-Bug: #1316127

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/4.1
Review: https://review.openstack.org/97202

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97202
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=f5f27b918e1d79b364f3fcc88180f84a773f9259
Submitter: Jenkins
Branch: stable/4.1

commit f5f27b918e1d79b364f3fcc88180f84a773f9259
Author: Tatyana Leontovich <email address hidden>
Date: Fri May 30 15:22:39 2014 +0000

    4.1.1 Raise SetProxy() exc if controllers are off

    Raise SetProxy() exception if all
    controllers are offline

    Change-Id: Ia58dc50344b76ebd49ade827c4e79d9d9eeee62e
    Related-Bug: #1316127

[Anastasia Palkina (apalkina)]

Verified on ISO #347
"build_id": "2014-07-23_02-01-14",
"ostf_sha": "c1b60d4bcee7cd26823079a86e99f3f65414498e",
"build_number": "347",
"auth_required": false,
"api": "1.0",
"nailgun_sha": "f5775d6b7f5a3853b28096e8c502ace566e7041f",
"production": "docker",
"fuelmain_sha": "74b9200955201fe763526ceb51607592274929cd",
"astute_sha": "fd9b8e3b6f59b2727b1b037054f10e0dd7bd37f1",
"feature_groups": ["mirantis"],
"release": "5.1",
"fuellib_sha": "fb0e84c954a33c912584bf35054b60914d2a2360"