Escape dollar sign in nova.conf

[Igor Shishkin]

%subj.

U1dSia3^_)'7$Y[.f>uM -- password

host_password=U1dSia3^_)'7$Y[.f>uM -- failed to start nova-compute because of parsing errors
host_password="U1dSia3^_)'7$$Y[.f>uM" -- works fine.

Please escape $ sign in nova.conf.

[Bogdan Dobrelya (bogdando)]

Probably it should be escaped in astute.yaml and puppet should use it as is, otherwise we will use the password which are not equal to the ones from fuel_settings hash (astute.yaml).

[Igor Shishkin (teran)]

Does anything but puppet uses passwords from astute.yaml?

[Bogdan Dobrelya (bogdando)]

OSTF will use the same password from Nailgun API as puppet does from astute.yaml.
Looks like we should either
*make escaping for every given module (puppet, ostf, etc.) relied on nova admin password on his own. Looks like an ugly hacking indeed.
*keep the escaped passwords in nailgun (cons: in general, escaping for some modules might vary)
or
*fix Oslo.config as appropriate. It should accept host_password=U1dSia3^_)'7$Y[.f>uM as is. The best one IMHO.

[Bogdan Dobrelya (bogdando)]

How to test:
$pass="qwe\$rty"
$pass_q=regsubst($pass, '(^.*\$.*$)' , '"\1"' ,'G')
$pass_r=regsubst($pass_q, '\${1}', '$$')
notify { $pass_q: }
notify { $pass_r: }

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92179

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/92179
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=96e4bea64880c48b0688f9be31205ff0bc4994d0
Submitter: Jenkins
Branch: master

commit 96e4bea64880c48b0688f9be31205ff0bc4994d0
Author: Bogdan Dobrelya <email address hidden>
Date: Mon May 5 21:17:25 2014 +0300

    Escape dollar symbol in host_password

    Escape $ and put the pass into the double quotes
    as a workaround for existing parsing issue

    Closes-bug: #1316120

    Change-Id: Ifd6146455083400252c272c9382a27a56e9c7024
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[Meg McRoberts (dreidellhasa)]

Added to "Fixed Issues" in 5.0 Release Notes.