Possibility to deploy OpenStack with vCenter without defining vCenter credentials

[Igor Shishkin]

Currently it's possible to deploy compute nodes with empty vCenter parameters.

Expected behaviour: display error without deployment task started.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/97494
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=98680a4245ef6c68e871e97a94560771ad766403
Submitter: Jenkins
Branch: master

commit 98680a4245ef6c68e871e97a94560771ad766403
Author: Julia Aranovich <email address hidden>
Date: Thu Jun 5 17:04:51 2014 +0400

    Settings improvements

    Closes-Bug:#1323749
    Related-Bug:#1314613

    Change-Id: I8e1824d3086d3e7362e5c12d25e29a79437accac

[Julia Aranovich (jkirnosova)]

This issue should be solved by adding vCenter credentials validation to the wizard.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/106807

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106807
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=99852136556e1c72001367127112aec2d4e833e7
Submitter: Jenkins
Branch: master

commit 99852136556e1c72001367127112aec2d4e833e7
Author: Alexandra Morozova <email address hidden>
Date: Tue Jul 15 12:42:20 2014 +0300

    vCenter credentials validation in wizard

    added client-side validation
    - changes to wizard.json with regexes
    - model change listener added

    Change-Id: I2d37821b95b00954b10809afd9c9c1aa7d6115ef
    Closes-bug: 1314613

[Igor Zinovik (izinovik)]

It is still possible to deploy OpenStack environment with empty vCenter fields.

Consider following scenario:
1. User created new environment with vCenter as hypervisor and filled all necessary fields in environment creation wizard.
2. After that he add new nodes to cluster.
3. Then on Settings tab it occasionally emptied all non validated fields (vCenter IP, username, password).
4. Then it hits "Deploy changes" and deployed starts.

Expected UI behaviour would be to validate blank fields and disable "Deploy changes" button.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/113821

[Andrey Danin (gcon-monolake)]

This problem is also confirmed for 5.0.1. I suggest to document that as a known issue for 5.0.1.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/5.0
Review: https://review.openstack.org/114143

[Julia Aranovich (jkirnosova)]

An appropriate change for 5.0.1 is overcomplicated and gives us a higher probability of related bugs : https://review.openstack.org/#/c/114143/

So, I share the opinion to make this bug a known issue in 5.0.1. And the fix will provided in next releases (started from 5.1).

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julia Aranovich (<email address hidden>) on branch: stable/5.0
Review: https://review.openstack.org/114143

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/113821
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=a50fa3710c838558d320857af5492b8351d33970
Submitter: Jenkins
Branch: master

commit a50fa3710c838558d320857af5492b8351d33970
Author: Igor Zinovik <email address hidden>
Date: Wed Aug 13 12:32:16 2014 +0400

    verify vCenter input fields on Settings tab

    - this change allows us to validate vCenter related fields on Settings
      tab; it will not allow user to start deployment with empty values
    - username field must be not empty
    - password field must be not empty
    - vCenter IP must be valid IPv4 address
    - while here rename 'ip_regex' to 'ipv4_regex', to reflect the fact
      that this regular expression does not validate IPv6 addresses
    - while here rename 'non_empty_regex' to 'non_empty_string', actually
      first name is missleading, regular expression match non empty strings,
      it does not means that RE itself is empty
    - while here adjust message in wizard about "vCenter IP" field, lets
      explicitly state that we expect IPv4 address as input value

    Change-Id: I60b0cbdf9a3801ba94483b1224f79786b37ce921
    Closes-bug: #1314613