Fuel for OpenStack

[nailgun] Network checker isn't covered by unit tests

Bug #1307543 reported by Ivan Kolodyazhny
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Fuel Python (Deprecated)
Fuel for OpenStack 5.1

Bug Description

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/network/checker.py has a lot ob logic and should be covered by unit tests

Ivan Kolodyazhny (e0ne)
Changed in fuel:
status: New → Confirmed
assignee: Fuel Python Team (fuel-python) → Ivan Kolodyazhny (e0ne)
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
importance: Undecided → Medium
Ivan Kolodyazhny (e0ne)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Rules for networks checking:
https://etherpad.openstack.org/p/limitations-of-networking-configuration

Existing network checker tests:
https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/test/integration/test_network_validation.py

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: none → 5.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/87767

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 5.0 → 5.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/87767
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=173ad479557ac961210641b127c4d9265888d3ef
Submitter: Jenkins
Branch: master

commit 173ad479557ac961210641b127c4d9265888d3ef
Author: Ivan Kolodyazhny <email address hidden>
Date: Tue Apr 15 21:21:32 2014 +0300

    Unit tests for NetworkCheck class

    Related-Bug: #1307543
    Change-Id: I4388f7c52bca405b820e41b0c0bfa432537c8381

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Ivan Kolodyazhny (e0ne) → Fuel Python Team (fuel-python)
status: In Progress → Confirmed
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote : Re: Network checker isn't covered by unit tests

Now network checker is covered partly. Please look at https://review.openstack.org/87767 and add UT similarly to increase coverage.

Changed in fuel:
status: Confirmed → Triaged
Dima Shulyak (dshulyak)
tags: added: low-hanging-fruit
Dmitry Ilyin (idv1985)
summary: - Network checker isn't covered by unit tests
+ [nailgun] Network checker isn't covered by unit tests
Revision history for this message
Dima Shulyak (dshulyak) wrote :

I will set it as Fix Commited because there is already some tests add in this patch https://review.openstack.org/87767.

Changed in fuel:
status: Triaged → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.