[nailgun] When new node is discovered warning presents: Invalid MAC is specified

[Anastasia Palkina]

"build_id": "2014-04-09_03-54-32",
"mirantis": "yes",
"build_number": "89",
"nailgun_sha": "00b2e1015e50e486f1c7215791724aaefaaf609d",
"ostf_sha": "17f2fe6e56452f8e2f01a385be4c4b87bf3698a8",
"fuelmain_sha": "97b539a540a4f15899de661d614edfda47767ab6",
"astute_sha": "35473eb08b16f4778283e993126a4fd15eb1d00f",
"release": "5.0",
"fuellib_sha": "9056ddfb1047c0384d2f03d7b7d32ba8cb4c54d8"

There are warnings for every new discovered node.

2014-04-09 08:58:02 WARNING

[7fce97fff700] (base) Invalid MAC is specified

2014-04-09 08:57:36 INFO

[7fcebd8b6700] (notification) Notification: topic: discover message: New node is discovered: 1 CPUs / 2.0 GB RAM / 0.206 TB HDD

[Mike Scherbakov (mihgen)]

Why 5.1 and low? Are you sure that Nailgun processes data correctly, and there is nothing worse happening behind the scene?
It hit a few folks already, and it's usually easy to fix. Unless we triage it, let's not slip it out of the release.

[Ihor Kalnytskyi (ikalnytskyi)]

We have this, since our discovery agent tries to make PUT request, and if it finished with 400 or 404 (seems the agent isn't registered in database), the agent is going to make POST request to register the node.

P.S: we have "Invalid MAC is specified" since the PUT validator has to make sure that a given mac address is exists in database, while in case of first request it obviously failed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/93711

[Mike Scherbakov (mihgen)]

Kamil, are you working on this?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/93711
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=779afd8882b119f7fc4eb69b3edd3e9efd63b42d
Submitter: Jenkins
Branch: master

commit 779afd8882b119f7fc4eb69b3edd3e9efd63b42d
Author: Kamil Sambor <email address hidden>
Date: Thu May 15 14:31:27 2014 +0200

    Changed order of calls to register new nodes

    Modified agent to checking if node was before registered, based on existence
    of nailgun_uid file. If file exist, only put is call, in other case when we
    try made post (if call was succes-201 or node exist 409, we call put method)

    Change-Id: Id1ef1650cf47c8e5fd7e844362b3fb41afad8fdd
    Closes-Bug: #1305017

[Evgeniy L (rustyrobot)]

Was reverted because of bug https://bugs.launchpad.net/fuel/+bug/1333629

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/108362

[Kamil Sambor (ksambor)]

I checked this and now with this patchset deployment is working normally.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/108362
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=2d1c53abc1280d0bb2c92dc51827e1db65de973f
Submitter: Jenkins
Branch: master

commit 2d1c53abc1280d0bb2c92dc51827e1db65de973f
Author: Kamil Sambor <email address hidden>
Date: Thu Jul 17 11:31:06 2014 +0200

    Changed order of calls to register new nodes

    Modified agent to checking if node was before registered, based on existence
    of nailgun_uid file. If file exist, only put is call, in other case when we
    try made post (if call was succes-201 or node exist 409, we call put method)

    Change-Id: I98680be7355e77512addb97f301c713cbf13c23c
    Closes-Bug: #1305017

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/109419

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/109419
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4cb2bb5375b6b7e6312b771ea4410b25285c41b1
Submitter: Jenkins
Branch: master

commit 4cb2bb5375b6b7e6312b771ea4410b25285c41b1
Author: Kamil Sambor <email address hidden>
Date: Thu Jul 24 23:29:37 2014 +0200

    Added the status 403 catching after post request

    Change-Id: Iaaddf05f3efecd6064f0b2d598eefaf35af8171f
    Closes-Bug: #1305017

[Dmitry Pyzhov (dpyzhov)]

Looks like our fix in master is not good enough

[Andrew Woodward (xarses)]

@Dmitry so this was reproduced? Please re-open the 5.1 status, set wont-fix and add 6.0

[Anastasia Palkina (apalkina)]

Reproduced with bug on ISO #11

"build_id": "2014-09-17_21-40-34", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "11", "auth_required": true, "api": "1.0", "nailgun_sha": "eb8f2b358ea4bb7eb0b2a0075e7ad3d3a905db0d", "production": "docker", "fuelmain_sha": "8ef433e939425eabd1034c0b70e90bdf888b69fd", "astute_sha": "f5fbd89d1e0e1f22ef9ab2af26da5ffbfbf24b13", "feature_groups": ["mirantis"], "release": "5.1", "release_versions": {"2014.1.1-5.1": {"VERSION": {"build_id": "2014-09-17_21-40-34", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "11", "api": "1.0", "nailgun_sha": "eb8f2b358ea4bb7eb0b2a0075e7ad3d3a905db0d", "production": "docker", "fuelmain_sha": "8ef433e939425eabd1034c0b70e90bdf888b69fd", "astute_sha": "f5fbd89d1e0e1f22ef9ab2af26da5ffbfbf24b13", "feature_groups": ["mirantis"], "release": "5.1", "fuellib_sha": "d9b16846e54f76c8ebe7764d2b5b8231d6b25079"}}}, "fuellib_sha": "d9b16846e54f76c8ebe7764d2b5b8231d6b25079"

2014-09-22 09:19:30 WARNING

[7f20c2fb7740] (base) Invalid MAC is specified
[pid: 487|app: 0|req: 71202/71202] 172.17.42.1 () {34 vars in 456 bytes} [Mon Sep 22 09:19:30 2014] PUT /api/nodes/agent/ => generated 24 bytes in 16 msecs (HTTP/1.1 400) 5 headers in 219 bytes (2 switches on core 0)

[Dmitry Pyzhov (dpyzhov)]

This warning message does not affect anything. And it is not possible to fix it in the current workflow.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/129627

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Mosesohn (<email address hidden>) on branch: stable/5.0
Review: https://review.openstack.org/129627