network verification fails with Socket error: Address already in use - bind(2)

[Dima Shulyak]

After second run network verification fails with Socket error: Address already in use

We need to close previous socket not only on ENOTCONN
https://github.com/stackforge/fuel-astute/blob/master/mcagents/net_probe.rb#L119

[Dima Shulyak (dshulyak)]

If anybody wants to reproduce it - just repeat Verify Networks 2 times

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/81735

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/81735
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=d7c6c4d00ffd6e2fa74da442f573e6f39049961e
Submitter: Jenkins
Branch: master

commit d7c6c4d00ffd6e2fa74da442f573e6f39049961e
Author: Dima Shulyak <email address hidden>
Date: Thu Mar 20 10:55:58 2014 +0200

    net_probe socket should be closed in any case

    network verification fails if started 2 times in a row
    with exception Socket error: Address already in use - bind(2)

    Change-Id: If6e32a4297a4ef74d5c7c21b564a3462831be003
    Closes-Bug: #1294754

[Anastasia Palkina (apalkina)]

Verified on ISO #40
"build_id": "2014-03-25_01-01-50",
"mirantis": "yes",
"build_number": "40",
"nailgun_sha": "3044c2054904525601c921387322a2978e821677",
"ostf_sha": "013c13ab033a6829ca4eeaa2476c30837e814902",
"fuelmain_sha": "f7ee8bcaa3d993395669f2bcae893176ff2b3bbe",
"astute_sha": "d7c6c4d00ffd6e2fa74da442f573e6f39049961e",
"release": "5.0",
"fuellib_sha": "3445ab7550486074ec8e47fdaed869c697991364"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/4.1
Review: https://review.openstack.org/84120

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84120
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=5bcacc84cdaee3b31f1178d92a1c0681dc6ce520
Submitter: Jenkins
Branch: stable/4.1

commit 5bcacc84cdaee3b31f1178d92a1c0681dc6ce520
Author: Dima Shulyak <email address hidden>
Date: Thu Mar 20 10:55:58 2014 +0200

    net_probe socket should be closed in any case

    network verification fails if started 2 times in a row
    with exception Socket error: Address already in use - bind(2)

    Change-Id: If6e32a4297a4ef74d5c7c21b564a3462831be003
    Closes-Bug: #1294754

[Andrey Sledzinskiy (asledzinskiy)]

verified on {"build_id": "2014-04-03_04-17-26", "mirantis": "yes", "build_number": "266", "nailgun_sha": "7a05e365240ab27c492b20585ef8ac8557102cc0", "ostf_sha": "de0222fed646525d248dc6892eeceab139d5c469", "fuelmain_sha": "16637e2ea0ae6fe9a773aceb9d76c6e3a75f6c3b", "astute_sha": "5bcacc84cdaee3b31f1178d92a1c0681dc6ce520", "release": "4.1", "fuellib_sha": "52e7f57695f33bafa5d84d524d77f1bc3a2289b2"}