[ui]Please, verify admin and tenant names via blacklist

Bug #1289405 reported by Nastya Urlapova on 2014-03-07
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Vitaly Kramskikh
Vitaly Kramskikh
Vitaly Kramskikh

Bug Description

Create black list for user and tenant names for openstack settings in fuelweb UI.
Don't allow use:
- admin
- services
- nova
- glance
- keystone

Changed in fuel:
milestone: none → 4.1.1
assignee: nobody → Vitaly Kramskikh (vkramskikh)
Ivan Kolodyazhny (e0ne) wrote :

Same checks must be on back-end side too

Changed in fuel:
milestone: 4.1.1 → 5.0
tags: added: backports-4.1.1
Changed in fuel:
status: New → Confirmed
Changed in fuel:
assignee: Vitaly Kramskikh (vkramskikh) → Fuel UI Team (fuel-ui)
Ivan Kolodyazhny (e0ne) on 2014-04-10
Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Ivan Kolodyazhny (e0ne)
Ivan Kolodyazhny (e0ne) on 2014-04-10
Changed in fuel:
assignee: Ivan Kolodyazhny (e0ne) → Fuel UI Team (fuel-ui)

Fix proposed to branch: master
Review: https://review.openstack.org/87270

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Vitaly Kramskikh (vkramskikh)
status: Confirmed → In Progress
Mike Scherbakov (mihgen) wrote :

Why is this? Is anything gonna be broken if we use one of reserved services names?

Reviewed: https://review.openstack.org/87270
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=f330990dde4bfe9fc2b82ddc52042eb6ece8859f
Submitter: Jenkins
Branch: master

commit f330990dde4bfe9fc2b82ddc52042eb6ece8859f
Author: Vitaly Kramskikh <email address hidden>
Date: Mon Apr 14 17:52:02 2014 +0400

    Do not allow usage of some reserved words as user or tenant name

    Change-Id: Ib8497f1433d620d9f1f78b85dd00e9951c4523f7
    Closes-Bug: #1289405

Changed in fuel:
status: In Progress → Fix Committed

verified on {"build_id": "2014-04-18_01-00-26", "mirantis": "yes", "build_number": "112", "nailgun_sha": "cd0f700fb38952139d55d26cc5d97940ce4e6c34", "production": "dev", "ostf_sha": "1ac04769cc8034438ccf1176860b25d0f5601c4a", "fuelmain_sha": "d1c962210f2dd88a2a810a52572597ea9e82d36f", "astute_sha": "0cb0b26773bd269000a14748e8ba49419462ecaf", "release": "5.0", "fuellib_sha": "6c7a341ce529d250e3e95d85361ada91f3f87686"}

Changed in fuel:
status: Fix Committed → Fix Released
Dmitry Pyzhov (dpyzhov) wrote :

Requires backport of refactoring

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers