Adaptec raid controller is mapped as removable device

[Vladimir Kozhukalov]

Found out that adaptec raid arrays are mapped into sysfs as removable devices. Discovery agent usually filters out all removable devices. Need to be fixed.

[Andrew Woodward (xarses)]

I spoke with some one on IRC a couple of weeks ago about the same issue, I don't know if it comes from attaching drives to the second head on which some controllers that i worked with in the past have labeled as external.

I'm not sure how we can filter these effectively with out adding all removable devices which could cause problems if they say, leave a usb stick or CD-Rom in the computer

[Vladimir Kuklin (vkuklin)]

related discussions are here:

http://lkml.iu.edu//hypermail/linux/kernel/0602.2/1231.html
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=404927

[Vladimir Kuklin (vkuklin)]

I think the only workaround we could apply is setting adaptec (connected to pci bus) as non-removable device explicitly as there are no cd-roms and usb pendrives made by adaptec.

[Miroslav Anashkin (manashkin)]

 Finally, we came to conclusion, that Nailgun agent should report all disk devices, including removable ones.
But Volume Manager on master node should by default make partitioning on non-removable devices only.
And customer should be given ability to include removable devices to partition scheme.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/75454

[Vladimir Kozhukalov (kozhukalov)]

Fast workaround: https://review.openstack.org/75454

Still working on making more comprehensive solution. It is supposed that agent will report all disks (removable and unremovable) and then we will allocate only unremovable disks by default and user will be able to allocate removable disks as well via UI.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/75454
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=490f5e419e84fe34662c519772c9647f6cb091ee
Submitter: Jenkins
Branch: master

commit 490f5e419e84fe34662c519772c9647f6cb091ee
Author: Vladimir Kozhukalov <email address hidden>
Date: Fri Feb 21 20:27:40 2014 +0400

    Workaround for Adaptec removable disk

    This is workaround for the case when Adaptec RAID
    controller is mappet into sysfs as removable device.

    Change-Id: I3a8f08040b0eaa972ab5f4c1bfc6342c29480822
    Closes-bug: #1282068