Neutron IP ranges check error

[Sergey Vasilenko]

I can't set custom IP range. Checking was incorrect on correct IP addresses.

3.2.1, ISO=65

[Aleksey Kasatkin (alekseyk-ru)]

I tested this locally with fake-UI and saw the problem with UI not Nailgun.

Networking settings for Public on UI doesn't pass with some IP values and UI prohibit use of changed settings.
No problem was found with Nailgun settings check and update.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: 3.2-fixes
Review: https://review.openstack.org/58487

[Mike Scherbakov (mihgen)]

Looks like netmask doesn't participate in validation

[Mike Scherbakov (mihgen)]

1) What is "external network" here stands for?
2) public ip range 10.0.1.4 - 10.0.5.100, netmask 255.255.0.0, gateway 10.0.5.200 - so I should not get such error, should I?

[Mike Scherbakov (mihgen)]

Why greater?

[Aleksey Kasatkin (alekseyk-ru)]

Mike,
1) External (and internal) networks are Neutron Virtual networks. We provide floating range for external network to allow Neutron to allocate IPs for VMs visible from outside. Floating range must be in Public CIDR as external is virtual and their IPs must fit to some physical network to be accessable.
2) You shouldn't get an error if floating range is in Public CIDR (10.0.0.0/16) and it doesn't intersect with Public range.

[Julia Aranovich (jkirnosova)]

>>> and it doesn't intersect with Public range.
This validation will be implemented within total networks refactoring.

All other cases are fixed in https://review.openstack.org/58487

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/58487
Committed: http://github.com/stackforge/fuel-web/commit/523b673edadb41f076284f2ca389b6724c64693c
Submitter: Jenkins
Branch: 3.2-fixes

commit 523b673edadb41f076284f2ca389b6724c64693c
Author: jkirnosova <email address hidden>
Date: Tue Nov 26 13:41:48 2013 +0400

    Fixes CIDR calculation

    Closes-Bug: #1254818

    Change-Id: Ida91d78f6a09489fd3bcbdbdd0d256b8b49e5363

[Anastasia Palkina (apalkina)]

Tested ISO #73
"release": "3.2.1",
"nailgun_sha": "523b673edadb41f076284f2ca389b6724c64693c",
"ostf_sha": "ea44d89ebe4e4fc7e24f64a3bdc6f9be6bcea9f6",
"astute_sha": "df6ddea3abc93fbe1cab9b4534d4d5e9508c95d6",
"fuellib_sha": "555081c25d85250c04e568f2287768387614ed5d"

[Egor Kotko (ykotko)]

The same on the release 4.0
Tested ISO #97

"release": "4.0",
"nailgun_sha": "a1f1c30cbb4f070bbd8d584019a189578b75eb53",
"ostf_sha": "f7d180ec6f8aacadde893b562f93afe419c82a38",
"astute_sha": "e0b90b9892b3d7b826496b776a0abb17d7469d4c",
"fuellib_sha": "9853139e1f9231a5c4f95697dc09946e2913d530"}

Error message on valid ip ranges when trying to save network settings:

Verification failed.
CIDR size for network 'public' is less than required

[Egor Kotko (ykotko)]

The same on the latest ISO release 3.2.1

Tested ISO #94
{"release": "3.2.1",
 "nailgun_sha": "71bb3cbc6aeda57d6676f5a8e87eb08b80f1ea11",
"ostf_sha": "f1db8d45af5f5aad391af1b353c3de5d0471b99c",
"astute_sha": "cb4868f0481d6c7d2d213ceb065ae3c40ab699ce",
 "fuellib_sha": "f916de800c2e40e351feba49f47b63b975749a82"}

Error message on valid ip ranges when trying to save network settings.

Steps to reproduse:
1. Create environment with Neutron type of network (VLAN/GRE)
2. In networks tab make custom entries into fields:

Public
ip range(start) 172.18.164.134 (end) 172.18.164.145
Vlan 325
Netmask 255.255.255.192
Gateway 172.18.164.129

Floating
ip range (start) 172.18.164.145 (end) 172.18.164.190
3. Press "Save Settings" buttom

Expected result:
Network settings should be saved

Actual result:
The error message:
 Verification failed.
CIDR size for network 'public' is less than required

ykotko@ykotko-pc:~$ ipcalc 172.18.164.129/26
Address: 172.18.164.129 10101100.00010010.10100100.10 000001
Netmask: 255.255.255.192 = 26 11111111.11111111.11111111.11 000000
Wildcard: 0.0.0.63 00000000.00000000.00000000.00 111111
=>
Network: 172.18.164.128/26 10101100.00010010.10100100.10 000000
HostMin: 172.18.164.129 10101100.00010010.10100100.10 000001
HostMax: 172.18.164.190 10101100.00010010.10100100.10 111110
Broadcast: 172.18.164.191 10101100.00010010.10100100.10 111111
Hosts/Net: 62 Class B, Private Internet

[Dmitry Pyzhov (dpyzhov)]

Egor, you have intersection between public and floating ranges

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/60236

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: 3.2-fixes
Review: https://review.openstack.org/60243

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60243
Committed: http://github.com/stackforge/fuel-web/commit/91630e8158a0edd555175392af704b28a678507d
Submitter: Jenkins
Branch: 3.2-fixes

commit 91630e8158a0edd555175392af704b28a678507d
Author: Aleksey Kasatkin <email address hidden>
Date: Thu Dec 5 15:43:02 2013 +0200

    [1254818] Neutron IP ranges check error

    "CIDR size for network 'public' is less than required". Fixed.
    Now public network_size is calculated in Nailgun.

    Closes-Bug: #1254818

    Change-Id: Ic70eaeccdcf314b2823622b8d6b28ea409e93f0b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60236
Committed: http://github.com/stackforge/fuel-web/commit/5685d4803d3e8afcdb83c04cc4c4bc1529d146d8
Submitter: Jenkins
Branch: master

commit 5685d4803d3e8afcdb83c04cc4c4bc1529d146d8
Author: Aleksey Kasatkin <email address hidden>
Date: Thu Dec 5 15:43:02 2013 +0200

    [1254818] Neutron IP ranges check error

    "CIDR size for network 'public' is less than required". Fixed.
    Now public network_size is calculated in Nailgun.

    Closes-Bug: #1254818

    Change-Id: Ic70eaeccdcf314b2823622b8d6b28ea409e93f0b

[Aleksandr Didenko (adidenko)]

{"release": "3.2.1", "nailgun_sha": "91630e8158a0edd555175392af704b28a678507d", "ostf_sha": "f1db8d45af5f5aad391af1b353c3de5d0471b99c", "astute_sha": "cb4868f0481d6c7d2d213ceb065ae3c40ab699ce", "fuellib_sha": "f916de800c2e40e351feba49f47b63b975749a82"}

Verified, bug is fixed.