Make string.letters PY3 compatible

Bug #1595786 reported by Ji.Wei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel Contrail plugin
Fix Released
Undecided
Ji.Wei
Fuel Plugins
Fix Committed
Undecided
Unassigned
OpenStack Object Storage (swift)
Fix Released
Undecided
jingtao liang
OpenStack Searchlight
Fix Released
Undecided
Ji.Wei
python-novaclient
Fix Released
Low
YaoZheng_ZTE

Bug Description

String.letters and related.Lowercase and.Uppercase are removed, please switch to string.ascii_letters, etc.

as:
https://github.com/openstack/nova/blob/04f2d81bb4d1e26482b613ab799bb38ce304e143/nova/tests/unit/api/openstack/compute/test_console_output.py#L102

Ji.Wei (jiwei)
Changed in nova:
assignee: nobody → Ji.Wei (jiwei)
affects: nova → python-novaclient
Ji.Wei (jiwei)
Changed in python-novaclient:
assignee: Ji.Wei (jiwei) → nobody
Changed in nova:
assignee: nobody → Ji.Wei (jiwei)
Changed in swift-swf:
assignee: nobody → jingtao liang (liang-jingtao)
Changed in python-novaclient:
assignee: nobody → YaoZheng_ZTE (zheng-yao1)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/333795

Changed in python-novaclient:
status: New → In Progress
Changed in python-novaclient:
importance: Undecided → Low
Ji.Wei (jiwei)
Changed in fuel-plugins:
assignee: nobody → Ji.Wei (jiwei)
affects: swift-swf → swift
Ji.Wei (jiwei)
Changed in searchlight:
assignee: nobody → Ji.Wei (jiwei)
Changed in fuel-plugin-contrail:
assignee: nobody → Ji.Wei (jiwei)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/333795
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=0c64947c6fda6855490958d2b95b74b1e4c1dfd7
Submitter: Jenkins
Branch: master

commit 0c64947c6fda6855490958d2b95b74b1e4c1dfd7
Author: zhengyao1 <email address hidden>
Date: Fri Jun 24 17:04:56 2016 +0800

    make string.letters python3 compatible

    The string.letters in python2 was supported. But in python3,
    string.letters was removed. In python3, recommend using
    string.ascii_letters instead. This patch fix it.

    Change-Id: I7bfe2b94c0c740d9143ddddc655f8086a537f24b
    Closes-Bug: #1595786

Changed in python-novaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/333712
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=c953e84e28b9b17e16bde7dfbbbdabca7acded13
Submitter: Jenkins
Branch: master

commit c953e84e28b9b17e16bde7dfbbbdabca7acded13
Author: liangjingtao <email address hidden>
Date: Fri Jun 24 11:50:20 2016 +0800

    Make string.letters PY3 compatible

    String.letters are removed in py3,use string.ascii_letters instead.

    Change-Id: I3c71b65b09b42dc954a3eb9e02894e5d3b12a3f4
    Closes-Bug: #1595786

Changed in swift:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugin-contrail (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334123

Changed in fuel-plugins:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to searchlight (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334127

Changed in searchlight:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334148

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to searchlight (master)

Reviewed: https://review.openstack.org/334127
Committed: https://git.openstack.org/cgit/openstack/searchlight/commit/?id=0b6a5c0f26cdb222a4d022a8dcb79495ac981258
Submitter: Jenkins
Branch: master

commit 0b6a5c0f26cdb222a4d022a8dcb79495ac981258
Author: Ji-Wei <email address hidden>
Date: Sat Jun 25 11:57:00 2016 +0800

    make string.letters python3 compatible

    The string.letters in python2 was supported. But in python3,
    string.letters was removed. In python3, recommend using
    string.ascii_letters instead. This patch fix it.

    Change-Id: Ib0444f1d527de4fcb0393bd04c93a64e9d79e3f9
    Closes-Bug: #1595786

Changed in searchlight:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by JiWei (<email address hidden>) on branch: master
Review: https://review.openstack.org/334148
Reason: There is another patch doing the same thing.

tags: added: python3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-plugin-contrail (master)

Change abandoned by JiWei (<email address hidden>) on branch: master
Review: https://review.openstack.org/334123
Reason: Patch in Merge Conflict

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugin-contrail (master)

Fix proposed to branch: master
Review: https://review.openstack.org/342057

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-plugin-contrail (master)

Reviewed: https://review.openstack.org/342057
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-contrail/commit/?id=c154fc3b6f87861fd68a00ef5279184ed4c0f9c6
Submitter: Jenkins
Branch: master

commit c154fc3b6f87861fd68a00ef5279184ed4c0f9c6
Author: Ji-Wei <email address hidden>
Date: Thu Jul 14 18:41:26 2016 +0800

    make string.letters python3 compatible

    The string.letters in python2 was supported. But in python3,
    string.letters was removed. In python3, recommend using
    string.ascii_letters instead.
    This patch fix it.

    Change-Id: I1965f1896f49eba45e77c917eb2fd8dd0bddd474
    Closes-Bug: #1595786

Changed in fuel-plugins:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/searchlight 1.0.0.0b2

This issue was fixed in the openstack/searchlight 1.0.0.0b2 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/swift 2.9.0

This issue was fixed in the openstack/swift 2.9.0 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/python-novaclient 5.0.0

This issue was fixed in the openstack/python-novaclient 5.0.0 release.

Illia Polliul (ipolliul)
Changed in fuel-plugin-contrail:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (feature/hummingbird)

Fix proposed to branch: feature/hummingbird
Review: https://review.openstack.org/363111

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (feature/hummingbird)
Download full text (84.1 KiB)

Reviewed: https://review.openstack.org/363111
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=1ab2a296f58ae76aeffef9f3f0fb90e15358be27
Submitter: Jenkins
Branch: feature/hummingbird

commit 3b5850836c59c46f2507a7f62aceccf4c37e5d41
Author: gecong1973 <email address hidden>
Date: Tue Aug 30 15:08:49 2016 +0800

    Remove white space between print and ()

    There is a white space between print and ()
    in /tempauth.py, This patch fix it

    Change-Id: Id3493bdef12223aa3a2bffc200db8710f5949101

commit f88e7fc0da2ed6a63e0ea3c3459d80772b3068cd
Author: zheng yin <email address hidden>
Date: Mon Aug 29 20:21:44 2016 +0800

    Clarify test case in common/ring/test_builder

    They use a bare assertRaises(ValueError, ring.RingBuilder, *,*,*), but
    it's not clear which one raises which ValueError(), so I extend them to
    validate the error strings as well.

    Change-Id: I63280a9fc47ff678fe143e635046a0b402fd4506

commit d68b1bd6ddf44c5088e9d02dcb2f1b802c71411b
Author: zhufl <email address hidden>
Date: Mon Aug 29 14:31:27 2016 +0800

    Remove unnecessary tearDown

    This is to remove unnecessary tearDown to keep code clean.

    Change-Id: Ie70e40d6b55f379b0cc9bc372a35705462cade8b

commit d2fc2614575b04fd9cab5ae589880b92eee9b186
Author: Matthew Oliver <email address hidden>
Date: Fri Aug 19 16:17:31 2016 +1000

    Authorise versioned write PUTs before copy

    Currently a versioned write PUT uses a pre-authed request to move
    it into the versioned container before checking whether the
    user is authorised. This can lead to some interesting behaviour
    whereby a user can select a versioned object path that it does not
    have access to, request a put on that versioned object, and this
    request will execute the copy part of the request before it fails
    due to lack of permissions.

    This patch changes the behaviour to be the same as versioned DELETE
    where the request is authorised before anything is moved.

    Change-Id: Ia8b92251718d10b1eb44a456f28d3d2569a30003
    Closes-Bug: #1562175

commit c1ef6539b6ba9d2e4354c9cd2eec8a0195cdb19f
Author: Clay Gerrard <email address hidden>
Date: Thu Aug 25 11:00:49 2016 -0700

    add test for expirer processes == process

    This is a follow up from a change that improved the error message.

    Related-Change: I3d12b79470d122b2114f9ee486b15d381f290f95

    Change-Id: I093801f3516a60b298c13e2aa026c11c68a63792

commit 01477c78c1163822de41484e914a0736e622085b
Author: zheng yin <email address hidden>
Date: Thu Aug 25 15:37:42 2016 +0800

    Fix ValueError information in obj/expirer

    I fix error information in raise ValueError(...)
    For example:
        if a>=b:
            # It should be under below and not 'a must be less than or equal to b'
            raise ValueError('a must be less than b')

    Change-Id: I3d12b79470d122b2114f9ee486b15d381f290f95

commit b81f53b964fdb8f3b50dd369ce2e194ee4dbb0b7
Author: zheng yin <email address hidden>
Date: Tue Aug 23 14:26:47 2016 +0800

    Improve readability in the obj server's unit tests

    This change improves the reada...

tags: added: in-feature-hummingbird
Revision history for this message
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

Changed in nova:
status: In Progress → New
assignee: Ji.Wei (jiwei) → nobody
Sean Dague (sdague)
no longer affects: nova
Ji.Wei (jiwei)
Changed in fuel-plugins:
assignee: Ji.Wei (jiwei) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.