Detach DB plugin fails deployment when additional Yaml parameter file is empty

[Alexander Kurenyshev]

Steps to reproduce:

1) Install master node
2) Clone, build and install plugin from here [1]
3) Create new cluster
3) Enable plugin, comment all strings at Additional plugin config
4) Add some nodes and one node with DB role
5) Deploy cluster

Expected behaviour:
Deploy passed and there are no errors at the log.

Actual behaviour:
Deploy failed on DB node with:
"Deployment has failed. Method granular_deploy. Deployment failed on nodes 1."

At the Astute log:
2015-09-16 16:05:20 ERR [641] No more tasks will be executed on the node 7
2015-09-16 16:05:20 ERR [641] Task '{"priority"=>400, "type"=>"puppet", "uids"=>["7"], "parameters"=>{"puppet_modules"=>"/etc/puppet/modules", "puppet_manifest"=>"database_hiera_override.pp", "timeout"=>120, "cwd"=>"/etc/fuel/plugins/detach-database-1.1/"}}' failed on node 7

Fuel RC2 used.

[1] https://github.com/stackforge/fuel-plugin-detach-database/

[Alex Schultz (alex-schultz)]

Actual error message from puppet:

2015-09-16 16:29:46 +0000 Puppet (err): settings_hash is not a hash or array when accessing it with remote_database at /etc/fuel/plugins/detach-database-
1.1/database_hiera_override.pp:17 on node node-1.test.domain.local

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/226883

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/226883
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugin-detach-database/commit/?id=6fb59cbae0d3cd41ae21ed813470280694110daf
Submitter: Jenkins
Branch: master

commit 6fb59cbae0d3cd41ae21ed813470280694110daf
Author: Matthew Mosesohn <email address hidden>
Date: Wed Sep 23 20:07:19 2015 +0300

    Allow empty additional config

    Empty UI config now will be ignored

    Change-Id: I5b20d4a399d6af08b2c0791edaead70305d19f79
    Closes-Bug: #1496519

[Vladimir Khlyunev (vkhlyunev)]

Can not be verified - https://github.com/stackforge/fuel-plugin-detach-database/blob/master/environment_config.yaml#L16-L18 this lines doesn't allow to pass empty config field.

[Anastasia Palkina (apalkina)]

Verified on ISO #507

I comment all strings in additional plugin config, and deployment was successful.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "507"
  build_id: "507"
  fuel-nailgun_sha: "8e954abd70ef0083109f34289de2553dcda544d4"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "ec7e212972ead554f21b52b9e165156665f659df"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "351d568fa3b3e4dd062054b91d766aa54d379867"
  fuelmenu_sha: "234cb4cbb30fbd2df00f388c28f31606d9cae15f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "94507c5e4dad6d8cfbd8f5d41aa8389d5335990a"