Database hosts aren't updated on nodes besides standalone-database nodes after database nodes addition

[Andrey Sledzinskiy]

Summary - Database hosts aren't updated on nodes besides standalone-database nodes after database nodes addition

Steps:
1. Install database plugin on master (https://github.com/stackforge/fuel-plugin-detach-database)
2. Create next cluster - all default values, 1 controller, 1 compute, 1 cinder, 3 standalone database nodes
3. Deploy cluster
4. After deployment add 1 database node and re-deploy
5. Check hiera database_nodes on all cluster nodes

Expected - databse nodes in hiera were updated for all cluster nodes
Actual - database nodes in hiera were updated only for standalone-database nodes

The only possible way it can affect user - failure of mysql ostf tests because it takes database nodes from hiera from controller and compare it with number of database nodes in cluster

[Matthew Mosesohn (raytrac3r)]

Only controller role needs to be updated because OSTF only connects to a controller node.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/215046

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/215046
Committed: https://git.openstack.org/cgit/stackforge/fuel-plugin-detach-database/commit/?id=981374df4c90c7869c0bd4aba37ba904c9a9880e
Submitter: Jenkins
Branch: master

commit 981374df4c90c7869c0bd4aba37ba904c9a9880e
Author: Matthew Mosesohn <email address hidden>
Date: Thu Aug 20 12:54:31 2015 +0300

    Add controller to update_required in role

    OSTF connects to the primary controller to query hiera
    for database hosts and compares it to wsrep_cluster_nodes
    inside the DB to ensure all nodes are joined to the cluster.
    That means controllers need to know all database_nodes in hiera.

    Change-Id: I7f33b3203299a66d1a1afe4ce11b27b896512bc4
    Closes-Bug: #1486891

[Andrey Sledzinskiy (asledzinskiy)]

verified on
{

    "build_id": "287",
    "build_number": "287",
    "release_versions":

{

    "2015.1.0-7.0":

{

    "VERSION":

{

    "build_id": "287",
    "build_number": "287",
    "api": "1.0",
    "fuel-library_sha": "43224223dab8cf9627b5ecf737e60216a3fdd114",
    "nailgun_sha": "46a7a2177a0b7ef91422284c1c90295fee8f5c84",
    "feature_groups":

            [
                "mirantis"
            ],
            "fuel-nailgun-agent_sha": "d7027952870a35db8dc52f185bb1158cdd3d1ebd",
            "openstack_version": "2015.1.0-7.0",
            "fuel-agent_sha": "082a47bf014002e515001be05f99040437281a2d",
            "production": "docker",
            "python-fuelclient_sha": "1ce8ecd8beb640f2f62f73435f4e18d1469979ac",
            "astute_sha": "a717657232721a7fafc67ff5e1c696c9dbeb0b95",
            "fuel-ostf_sha": "1f08e6e71021179b9881a824d9c999957fcc7045",
            "release": "7.0",
            "fuelmain_sha": "6b83d6a6a75bf7bca3177fcf63b2eebbf1ad0a85"
        }
    }

},
"auth_required": true,
"api": "1.0",
"fuel-library_sha": "43224223dab8cf9627b5ecf737e60216a3fdd114",
"nailgun_sha": "46a7a2177a0b7ef91422284c1c90295fee8f5c84",
"feature_groups":

    [
        "mirantis"
    ],
    "fuel-nailgun-agent_sha": "d7027952870a35db8dc52f185bb1158cdd3d1ebd",
    "openstack_version": "2015.1.0-7.0",
    "fuel-agent_sha": "082a47bf014002e515001be05f99040437281a2d",
    "production": "docker",
    "python-fuelclient_sha": "1ce8ecd8beb640f2f62f73435f4e18d1469979ac",
    "astute_sha": "a717657232721a7fafc67ff5e1c696c9dbeb0b95",
    "fuel-ostf_sha": "1f08e6e71021179b9881a824d9c999957fcc7045",
    "release": "7.0",
    "fuelmain_sha": "6b83d6a6a75bf7bca3177fcf63b2eebbf1ad0a85"

}