Deployment failed due to patching failure in compute_post_deployment.py

Bug #1683288 reported by Jianghua Wang on 2017-04-17
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
fuel-plugin-xenserver
High
Jianghua Wang

Bug Description

Recently MOS9.2 has some updates. it has picked up the fix on neutron-rootwrap-xen-dom0. But in our xenserver fule plugin, it still tries to patch this file in compute_post_deployment. So it failed and stopped the deployment.
Beyond this failure, it exposes an bigger issue on the patching mechanism. As we can't predict when MOS will pick your change from the upstream. We may consider to check the status before really patching it.
http://mirror.fuel-infra.org/mos-repos/ubuntu/9.2/dists/mos9.0/main/source/
../
Release 08-Jun-2016 08:59 84
Sources.gz 29-Mar-2017 09:46 169091
root@node-4:~# patch -d /usr/bin -p2 -i /etc/fuel/plugins/fuel-plugin-xenserver-4.90/patchset/fix-xenapi-returncode.patch
patching file neutron-rootwrap-xen-dom0
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
7 out of 7 hunks ignored – saving rejects to file neutron-rootwrap-xen-dom0.rej
root@node-4:~# echo $?
1

Changed in fuel-plugin-xenserver:
assignee: nobody → Jianghua Wang (wjh-fresh)
description: updated
Changed in fuel-plugin-xenserver:
status: New → In Progress
Revision history for this message
Jianghua Wang (wjh-fresh) wrote :

See the fixing patch: https://review.openstack.org/#/c/457100/

The solution is to use '--forward' the option for patch command, so that it will only apply patch when it's forwarding changing but ignore the patch if that's reversing or applied already.

Changed in fuel-plugin-xenserver:
importance: Undecided → High
Changed in fuel-plugin-xenserver:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers