Firewall driver for vCenter doesn't support vif:binding_details dvs_port_group_name

[Thomas Bachman]

The Liberty and Mitaka versions of the firewall driver for vCenter doesn't support passing port groups using the binding:vif_details attribute "dvs_port_group_name". This seen using the group based policy plugin with a DVS agent, which gives exceptions like this:

http://pastebin.com/zb0iJZG9

[Elena Kosareva (ekosareva)]

Fix was prepared but we have no appropriate environment to reproduce and test it. Please, get https://github.com/Mirantis/vmware-dvs/pull/129 and check it. If this changes will fix the problem we will merge this fix.

[Thomas Bachman (tbachman)]

The proposed fix is correct, but not complete. There is a similar call here:

https://github.com/Mirantis/vmware-dvs/blob/liberty/vmware_dvs/agent/firewalls/vcenter_firewall.py#L168-L176

It needs the same change.

[Elena Kosareva (ekosareva)]

Thanks, Thomas. I'll check it again, but as I know, mentioned changes above is already contains in request.

[Thomas Bachman (tbachman)]

Ah -- my mistake. You are correct. This patch is good.

cheers,

-Thomas