Cinder

Delete of default cgsnapshot group type is not blocked

Bug #1710937 reported by David Rosales on 2017-08-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	High	Matthew Edmonds

Bug Description

There is currently nothing blocking the delete of the default cgsnapshot group type. If this is deleted, group operations for drivers not yet implementing the new group APIs will fail since getting the default cgsnapshot group type is the first step in the flow.

2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types [req-882373a1-186f-48d8-a4a3-4219f930f322 0688b01e6439ca32d698d20789d52169126fb41fb1a4ddafcebb97d854e836c9 b7b42ba7d209420ca2651c03be5f1a97 - default default] Default cgsnapshot type default_cgsnapshot_type is not found.: GroupTypeNotFoundByName: Group type with name default_cgsnapshot_type could not be found.
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types Traceback (most recent call last):
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types File "/usr/lib/python2.7/site-packages/cinder/volume/group_types.py", line 153, in get_default_cgsnapshot_type
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types grp_type = get_group_type_by_name(ctxt, DEFAULT_CGSNAPSHOT_TYPE)
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types File "/usr/lib/python2.7/site-packages/cinder/volume/group_types.py", line 121, in get_group_type_by_name
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types return db.group_type_get_by_name(context, name)
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types File "/usr/lib/python2.7/site-packages/cinder/db/api.py", line 751, in group_type_get_by_name
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types return IMPL.group_type_get_by_name(context, name)
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types File "/usr/lib/python2.7/site-packages/cinder/db/sqlalchemy/api.py", line 195, in wrapper
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types return f(*args, **kwargs)
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types File "/usr/lib/python2.7/site-packages/cinder/db/sqlalchemy/api.py", line 3847, in group_type_get_by_name
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types return _group_type_get_by_name(context, name)
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types File "/usr/lib/python2.7/site-packages/cinder/db/sqlalchemy/api.py", line 195, in wrapper
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types return f(*args, **kwargs)
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types File "/usr/lib/python2.7/site-packages/cinder/db/sqlalchemy/api.py", line 3831, in _group_type_get_by_name
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types raise exception.GroupTypeNotFoundByName(group_type_name=name)
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types GroupTypeNotFoundByName: Group type with name default_cgsnapshot_type could not be found.
2017-08-14 12:04:23.555 23107 ERROR cinder.volume.group_types
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault [req-882373a1-186f-48d8-a4a3-4219f930f322 0688b01e6439ca32d698d20789d52169126fb41fb1a4ddafcebb97d854e836c9 b7b42ba7d209420ca2651c03be5f1a97 - default default] Caught error: <type 'exceptions.KeyError'> 'id': KeyError: 'id'
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault Traceback (most recent call last):
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/cinder/api/middleware/fault.py", line 80, in __call__
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault return req.get_response(self.application)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/webob/request.py", line 1316, in send
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault application, catch_exc_info=False)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/webob/request.py", line 1280, in call_application
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault app_iter = application(self.environ, start_response)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/webob/dec.py", line 145, in __call__
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault return resp(environ, start_response)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/webob/dec.py", line 131, in __call__
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault resp = self.call_func(req, *args, **self.kwargs)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/webob/dec.py", line 196, in call_func
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault return self.func(req, *args, **kwargs)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/osprofiler/web.py", line 108, in __call__
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault return request.get_response(self.application)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/webob/request.py", line 1316, in send
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault application, catch_exc_info=False)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/webob/request.py", line 1280, in call_application
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault app_iter = application(self.environ, start_response)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/webob/dec.py", line 131, in __call__

2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/cinder/api/openstack/wsgi.py", line 905, in _process_stack
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault action_result = self.dispatch(meth, request, action_args)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/cinder/api/openstack/wsgi.py", line 1000, in dispatch
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault return method(req=request, **action_args)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/cinder/api/openstack/wsgi.py", line 1166, in version_select
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault return func.func(self, *args, **kwargs)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/cinder/api/v3/groups.py", line 221, in create
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault self._check_default_cgsnapshot_type(group_type)
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/cinder/api/v3/groups.py", line 50, in _check_default_cgsnapshot_type
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault if group_types.is_default_cgsnapshot_type(group_type_id):
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault File "/usr/lib/python2.7/site-packages/cinder/volume/group_types.py", line 165, in is_default_cgsnapshot_type
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault return group_type_id == cgsnap_type['id']
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault KeyError: 'id'
2017-08-14 12:04:23.572 23107 ERROR cinder.api.middleware.fault

See original description

Tags:

jolacawoye (trethgfh) on 2017-08-31

summary:	- Cinder allows delete of default cgsnapshot group type + www.mcafee.com/activate - 1-8883052111 \| www.mcafee.com Download + 18883052111 www mcafee com setup
tags:	added: mcafee support
description:	updated

David Rosales (darosale) on 2017-09-07

summary:	- www.mcafee.com/activate - 1-8883052111 \| www.mcafee.com Download - 18883052111 www mcafee com setup + Delete of default cgsnapshot group type is not blocked
description:	updated

Revision history for this message

David Rosales (darosale) wrote on 2017-10-23:

Any updates here?

Matthew Edmonds (edmondsw) on 2017-10-24

affects:

fuel-plugin-contrail → cinder

Eric Harney (eharney) on 2017-10-25

tags:	removed: mcafee support
Changed in cinder:
importance:	Undecided → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-11-16: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/520607

Changed in cinder:
assignee:	nobody → Matthew Edmonds (edmondsw)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-12-13: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/520607
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=be7b476d562f79d649724555aeadfad60127e356
Submitter: Zuul
Branch: master

commit be7b476d562f79d649724555aeadfad60127e356
Author: Matthew Edmonds <email address hidden>
Date: Thu Nov 16 09:27:08 2017 -0500

handle no default_cgsnapshot_type

    If default_cgsnapshot_type has been deleted, group operations for
    drivers relying on the generic volume group implementation were failing
    with a KeyError while attempting to determine if the targeted group was
    default_cgsnapshot_type. This fixes that by using a comparison that
    allows for the possibility that default_cgsnapshot_type does not
    exist.

Change-Id: Ic220ea4d8a6e83293e5237acfb07b1a417293803
Closes-Bug: #1710937

Changed in cinder:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-01-17: Fix proposed to cinder (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/534843

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-01-18: Fix merged to cinder (stable/pike)

Reviewed: https://review.openstack.org/534843
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=29456fa515d18343ae7f98a50455eb2fd84fce47
Submitter: Zuul
Branch: stable/pike

commit 29456fa515d18343ae7f98a50455eb2fd84fce47
Author: Matthew Edmonds <email address hidden>
Date: Thu Nov 16 09:27:08 2017 -0500

handle no default_cgsnapshot_type

    Change-Id: Ic220ea4d8a6e83293e5237acfb07b1a417293803
    Closes-Bug: #1710937
    (cherry picked from commit be7b476d562f79d649724555aeadfad60127e356)