Special characters can be used in GCS plugin url configuration fields.

Bug #1621898 reported by Vitalii Yerys on 2016-09-09
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fuel-plugin-cinder-gcs
Medium
fuel-plugin-cinder-gcs

Bug Description

According to RFC 1738 it is not recommended to use unsafe special characters, while in plugin configuration fields it is possible to set special characters inside the body of URL:

For example I was able to set such Auth token url:

https://accou#$@!%^&{}[][}@! &*()nts.google.com/{!/0412{{{42/to!@321ken

Vitalii Yerys (vyerys) on 2016-09-12
Changed in fuel-plugin-cinder-gcs:
assignee: nobody → fuel-plugin-cinder-gcs (fuel-plugin-cinder-gcs)
Taras Kostyuk (tkostyuk) on 2016-09-13
Changed in fuel-plugin-cinder-gcs:
status: New → In Progress

Reviewed: https://review.openstack.org/369282
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-cinder-gcs/commit/?id=a0e8b83c100a735816bf9eed819a5ceecbacef73
Submitter: Jenkins
Branch: master

commit a0e8b83c100a735816bf9eed819a5ceecbacef73
Author: Taras Kostyuk <email address hidden>
Date: Tue Sep 13 12:26:04 2016 +0300

    More strict regex for UI URL fields

    Closes-Bug: #1621898

    The regex added by this commit is taken from
    https://github.com/openstack/fuel-ui/blob/stable/mitaka/static/views/custom_controls.js#L72
    which is regex used for validating Repositories URI in Fuel UI.

    Change-Id: Id9387135260822f2e1b5527f432fc9e30512f2f2

Changed in fuel-plugin-cinder-gcs:
status: In Progress → Fix Committed
Vitalii Yerys (vyerys) on 2016-09-16
Changed in fuel-plugin-cinder-gcs:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers