Re-apply revision 94, 95, 98 once Quantal hits EOL.

Bug #1095425 reported by Robert Bruce Park
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Friends
Fix Released
Low
Robert Bruce Park

Bug Description

So revision 94 was this really beautiful commit where we dropped a workaround for an ugly bug in libaccounts-glib, except unfortunately the fix for that bug exists only in Raring, not in Quantal, so that commit broke Quantal, and got reverted in r107.

Similarly, 95 and 98 adopted some python 3.3-only language features that break in python 3.2, thus preventing Friends from running on Quantal. Those got reverted in commits 108 and 109.

Once Quantal hits EOL, please revert r 107, 108, 109, and then we can move on with our lives. Here's the command to do this, so you don't need to look it up later:

bzr merge -r 109..106

(this preserves commit 106 but reverts the changes introduced by 107, 108, and 109)

Related branches

summary: - Re-apply revision 94 once Quantal hits EOL.
+ Re-apply revision 94, 95, 98 once Quantal hits EOL.
Revision history for this message
Robert Bruce Park (robru) wrote :

I confirmed in my Quantal VM that lp:friends now experiences zero test failures as of revision 109.

description: updated
description: updated
Changed in friends (Ubuntu):
milestone: none → later
assignee: nobody → Robert Bruce Park (robru)
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Robert Bruce Park (robru) wrote :

Twitter rate limiter's new JSON cachefile employs a similar ugly hack for supporting Quantal that I'd like to drop ASAP.

Changed in friends (Ubuntu):
assignee: Robert Bruce Park (robru) → nobody
Revision history for this message
Robert Bruce Park (robru) wrote :

Ok, that merge didn't merge cleanly at all, it's bitrotted way too much ;-)

But I've just dropped a bunch of quantal / python 3.2 compat code from trunk-next, which I hope we can land early in the S cycle, once the phablet images are solidly based on raring.

Changed in friends:
status: Triaged → Fix Committed
no longer affects: friends (Ubuntu)
Changed in friends:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.