sharedmodel schema needs to be refined.
Bug #1066165 reported by
Robert Bruce Park
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Friends |
Fix Released
|
Medium
|
Robert Bruce Park | ||
Bug Description
Currently the 'comments' column is an 'as' (array of strings) type, but this is a lossy idea: comments are stored with no author name, author avatar, etc. Quite useless.
What we should really do instead is drop the 'comments' column altogether, and then publish a whole new row for each comment. "Comments" and "Posts" are essentially identical, so using the same schema for each should be a winning idea. Then we can have a new schema column called "parent_id" which would contain the message_id that the comment is a response to. This will allow clients to build a tree-like data structure for displaying threaded comment discussions to the user.
Related branches
lp:~robru/friends/replies
- Ken VanDine: Pending requested
-
Diff: 398 lines (+101/-43)10 files modifiedfriends/main.py (+6/-0)
friends/protocols/facebook.py (+22/-13)
friends/tests/test_account.py (+2/-2)
friends/tests/test_avatars.py (+3/-2)
friends/tests/test_facebook.py (+48/-12)
friends/tests/test_foursquare.py (+1/-1)
friends/tests/test_model.py (+2/-2)
friends/tests/test_twitter.py (+4/-4)
friends/utils/avatar.py (+13/-6)
friends/utils/model.py (+0/-1)
| Changed in friends: | |
| assignee: | nobody → Robert Bruce Park (robru) |
| Changed in friends: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in friends: | |
| status: | Triaged → Fix Committed |
| Changed in friends: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
