plugins are not storing avatar data from services into sharedmodel.
Bug #1066105 reported by
Robert Bruce Park
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Friends |
Fix Released
|
High
|
Ken VanDine | ||
Bug Description
Basically the sharedmodel needs to be closely audited for data completeness. I *know* there is a lot of data that the services are reporting to us, that is not making it into the model, but I'm not sure what is important to record and what isn't.
Related branches
lp:~robru/friends/replies
- Ken VanDine: Pending requested
-
Diff: 398 lines (+101/-43)10 files modifiedfriends/main.py (+6/-0)
friends/protocols/facebook.py (+22/-13)
friends/tests/test_account.py (+2/-2)
friends/tests/test_avatars.py (+3/-2)
friends/tests/test_facebook.py (+48/-12)
friends/tests/test_foursquare.py (+1/-1)
friends/tests/test_model.py (+2/-2)
friends/tests/test_twitter.py (+4/-4)
friends/utils/avatar.py (+13/-6)
friends/utils/model.py (+0/-1)
Revision history for this message
| Robert Bruce Park (robru) wrote | #1 |
| Changed in friends: | |
| importance: | Undecided → High |
| status: | New → Triaged |
Revision history for this message
| Robert Bruce Park (robru) wrote | #2 |
Revision history for this message
| Robert Bruce Park (robru) wrote | #3 |
Revision history for this message
| Robert Bruce Park (robru) wrote | #4 |
Revision history for this message
| Robert Bruce Park (robru) wrote | #5 |
| Changed in friends: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Ideally we should be using our own Avatar logic such that the sharedmodel contains only the local cached URIs, not the live URLs. That will ensure all frontends benefit equally from the caching.