Freezer api fails to encode return objects as json

[Memo Garcia]

when a GET requests gets made to the api, it fails to respond saying:

"dict" object has no attribute 'encode'

so basically falcon is being supplied with a dict rather than a string for the response body,

a solution could be to wrap the response in a json format.

[Domhnall Walsh (domhnall-walsh)]

This affects the stable/mitaka branch, and most likely the stable/liberty branch, but *not* master.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/331237

[OpenStack Infra (hudson-openstack)]

Change abandoned by Domhnall Walsh (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/331237
Reason: Cannot change the requirement for falcon, adopting a different approach.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/334920

[Domhnall Walsh (domhnall-walsh)]

This problem showed up on the stable/mitaka branch but is actually an issue with the invocation of middleware and how that varies between version of Falcon. On master, the approach used is the "modern" one for falcon >= 0.2.0b1, whereas on stable/mitaka (and stable/liberty) it's the older approach, which are incompatible with one another.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/334920
Committed: https://git.openstack.org/cgit/openstack/freezer-api/commit/?id=a28be0565954518fe12a3513963e7cecce6dc67b
Submitter: Jenkins
Branch: master

commit a28be0565954518fe12a3513963e7cecce6dc67b
Author: Domhnall Walsh <email address hidden>
Date: Tue Jun 28 11:40:59 2016 +0100

    Fix Middleware loading for falcon >= 0.1.6

    API now loads middleware correctly for all version of falcon
    specified in requirements.txt.

    Change-Id: I337cff087b7b34e760e0555591e1929979450c39
    Closes-Bug: #1593212

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/337230

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337230
Committed: https://git.openstack.org/cgit/openstack/freezer-api/commit/?id=40862a1daf7b1af18c22556bce86450e3116f039
Submitter: Jenkins
Branch: stable/mitaka

commit 40862a1daf7b1af18c22556bce86450e3116f039
Author: Domhnall Walsh <email address hidden>
Date: Tue Jun 28 11:40:59 2016 +0100

    Fix Middleware loading for falcon >= 0.1.6

    API now loads middleware correctly for all version of falcon
    specified in requirements.txt.

    Closes-Bug: #1593212

    Conflicts:
     freezer_api/api/common/middleware.py
     freezer_api/api/common/utils.py
     freezer_api/cmd/api.py
     freezer_api/service.py

    Change-Id: I9b82304cd937598a2d513e2bca709569e20a4f83

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337626
Committed: https://git.openstack.org/cgit/openstack/freezer-api/commit/?id=0c6de9b7fd0968e2bd9a27184c837f8158014efd
Submitter: Jenkins
Branch: stable/liberty

commit 0c6de9b7fd0968e2bd9a27184c837f8158014efd
Author: Domhnall Walsh <email address hidden>
Date: Tue Jun 28 11:40:59 2016 +0100

    Fix Middleware loading for falcon >= 0.1.6

    API now loads middleware correctly for all version of falcon
    specified in requirements.txt.

    Cherry-pick from https://review.openstack.org/#/c/334920/
    and pre_test_hook.sh from https://review.openstack.org/#/c/319950/

    Conflicts:
     freezer_api/api/common/middleware.py
     freezer_api/api/common/utils.py
     freezer_api/cmd/api.py
     freezer_api/service.py

    Change-Id: I337cff087b7b34e760e0555591e1929979450c39
    Closes-Bug: #1593212

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/freezer-api 3.0.0.0b2 development milestone.