Freezer-agent allow to create backup of non existing directories

Bug #1553146 reported by Pierre-Arthur MATHIEU
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Backup/Restore and DR (Freezer)
Fix Released
Medium
Pierre-Arthur MATHIEU
Mitaka
Triaged
Undecided
Unassigned

Bug Description

Backup:
ls /djewkjdklewjdklewjl
ls: cannot access /djewkjdklewjdklewjl: No such file or director
freezer-agent --action backup --mode fs --storage local --path-to-backup /djewkjdklewjdklewjl --container /tmp/backup --backup-name backup-testdkelwdelw

Logs:
2016-03-04 11:03:47,399 root INFO log file at /var/log/freezer.log
2016-03-04 11:03:47,400 root INFO [*] Job execution Started at: 2016-03-04 11:03:47
2016-03-04 11:03:47,451 root INFO [*] No LVM requested/configured
2016-03-04 11:03:47,451 root WARNING [*] Directory /root/.freezer found!
2016-03-04 11:03:47,455 root INFO Tar engine backup stream enter
2016-03-04 11:03:47,455 root INFO Execution command:
/bin/tar --create -z --warning=none --no-check-device --one-file-system --preserve-permissions --same-owner --seek --ignore-failed-read --listed-incremental=/root/.freezer/tar_metadata_padawan-ccp-c0-m1-mgmt_backup-testdkelwdelw_1457089427_0 djewkjdklewjdklewjl
2016-03-04 11:03:47,467 root INFO Tar engine streaming end
2016-03-04 11:03:47,471 root INFO [*] Job execution Finished, at: 2016-03-04 11:03:47
2016-03-04 11:03:47,471 root INFO [*] Job time Elapsed: 0:00:00.070626

Restore:
root@padawan-ccp-c0-m1-mgmt:/home/stack/scratch/ansible/next/hos/ansible# freezer-agent --action restore --mode fs --storage local --restore-abs-path /tmp/restore/ --container /tmp/backup --backup-name backup-testdkelwdelw
root@padawan-ccp-c0-m1-mgmt:/home/stack/scratch/ansible/next/hos/ansible# ls /tmp/restore

Logs:
2016-03-04 11:15:45,262 root INFO log file at /var/log/freezer.log
2016-03-04 11:15:45,263 root INFO [*] Job execution Started at: 2016-03-04 11:15:45
2016-03-04 11:15:45,263 root INFO [*] Executing FS restore...
2016-03-04 11:15:45,264 root INFO Creation restore path: /tmp/restore/
2016-03-04 11:15:45,264 root INFO Creation restore path completed
2016-03-04 11:15:45,264 root INFO Restore backup padawan-ccp-c0-m1-mgmt_backup-testdkelwdelw_1457089427_0
2016-03-04 11:15:45,284 root INFO [*] Pipe closed as EOF reached. Data transmitted successfully
2016-03-04 11:15:45,291 root INFO Restore backup padawan-ccp-c0-m1-mgmt_backup-testdkelwdelw_1457089433_1
2016-03-04 11:15:45,305 root INFO [*] Pipe closed as EOF reached. Data transmitted successfully
2016-03-04 11:15:45,311 root INFO [*] Restore execution successfully executed for backup name padawan-ccp-c0-m1-mgmt_backup-testdkelwdelw_1457089433_1
2016-03-04 11:15:45,312 root INFO [*] Job execution Finished, at: 2016-03-04 11:15:45
2016-03-04 11:15:45,312 root INFO [*] Job time Elapsed: 0:00:00.048993

Changed in freezer:
milestone: none → newton-2
assignee: nobody → Pierre-Arthur MATHIEU (pi3rra)
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to freezer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/339089

Changed in freezer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to freezer (master)

Reviewed: https://review.openstack.org/339089
Committed: https://git.openstack.org/cgit/openstack/freezer/commit/?id=1c9bba42acd785eeb2f2a8577becbf602d42e5c0
Submitter: Jenkins
Branch: master

commit 1c9bba42acd785eeb2f2a8577becbf602d42e5c0
Author: Pierre-Arthur MATHIEU <email address hidden>
Date: Thu Jul 7 16:41:05 2016 +0100

    Fail on non-existing path to backup

    Change-Id: I897444a8eba24b61fcab4a694ad73b6688e31fb8
    Closes-Bug: #1553146

Changed in freezer:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/freezer 3.0.0.0b3

This issue was fixed in the openstack/freezer 3.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.