freezer-agent --config configfile parse error

[jiaopengju]

I'am doing some development with using freezerclient and found some errors.

After analysis， I found that freezer-scheduler will call 'freezer-agent --config file1' to run the backup/restore task. But it was failed when doing nova backups, it is because that the config opts in file1 were not parsed to CONF, but EngineManager uses the CONF.engine_name(now it is the default 'tar'). I think this should be fixed.

configfile content as below:

[action]
engine_name = nova
backup_name = backup40ad1e61-74a2-4870-aa52-2c33f193f3e2
container = freezer
no_incremental = true
storage = swift
mode = nova
action = backup
nova_inst_id = 477a6fd7-e788-4111-89de-316384e8df35

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493044
Committed: https://git.openstack.org/cgit/openstack/freezer/commit/?id=50df2c8ca3e1083ea53a0937a83a35bb9ed1d499
Submitter: Jenkins
Branch: master

commit 50df2c8ca3e1083ea53a0937a83a35bb9ed1d499
Author: Pengju Jiao <email address hidden>
Date: Fri Aug 11 23:15:55 2017 +0800

    Fix backup nova instance with creating job error

    Currently, it will fail when doing nova backup with creating
    a backup job. It is because freezer-scheduler will call freezer-agent
    with '--config config-file', but the config opts in config-file (from
    job file) were not parsed to CONF, at the same time EngineManager uses
    the CONF.engine_name(now it is the default 'tar'), this will lead the
    code go into wrong branch, although it will not throw errors and show
    the backup is success, but when doing restore after this, we can find
    that the backup data can not be used and print EOF error in log file.

    This patch will fix the above issue.

    Change-Id: I826e4ed71dfd2cde6103e8432faba7adb4648c36
    Closes-Bug: #1710238

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/493858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493858
Committed: https://git.openstack.org/cgit/openstack/freezer/commit/?id=c0c234f5b0ed37732527031b6199651d02f20fd9
Submitter: Jenkins
Branch: stable/pike

commit c0c234f5b0ed37732527031b6199651d02f20fd9
Author: Pengju Jiao <email address hidden>
Date: Fri Aug 11 23:15:55 2017 +0800

    Fix backup nova instance with creating job error

    Currently, it will fail when doing nova backup with creating
    a backup job. It is because freezer-scheduler will call freezer-agent
    with '--config config-file', but the config opts in config-file (from
    job file) were not parsed to CONF, at the same time EngineManager uses
    the CONF.engine_name(now it is the default 'tar'), this will lead the
    code go into wrong branch, although it will not throw errors and show
    the backup is success, but when doing restore after this, we can find
    that the backup data can not be used and print EOF error in log file.

    This patch will fix the above issue.

    Change-Id: I826e4ed71dfd2cde6103e8432faba7adb4648c36
    Closes-Bug: #1710238
    (cherry picked from commit 50df2c8ca3e1083ea53a0937a83a35bb9ed1d499)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/freezer 6.0.0.0b2 development milestone.